Closed
Bug 688673
Opened 13 years ago
Closed 13 years ago
Github support for autolog
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mdas, Assigned: mdas)
Details
Attachments
(1 file, 1 obsolete file)
9.75 KB,
patch
|
Details | Diff | Splinter Review |
Autolog current supports hg repos, but not github ones. Need this functionality for dxr (and potentially other projects?) since development is being done on github.
Assignee | ||
Comment 1•13 years ago
|
||
This also adds dxr to the list of trees being hosted. I'm not a fan of the gitRepoNames hack in js/Config.js, since it repeats values that are in repoNames. It's used to check if the repository we're looking at is in git or not, and it's really only used for generating links. The alternative that I was considering was to have two values, hgRepoNames and gitRepoNames, and then just merging the two to be repoNames with jQuery.extend(), since repoNames is used in a few js files for checking which tree we're on, but both solutions sounded icky. Advice?
Attachment #561949 -
Flags: review?(jgriffin)
Comment 2•13 years ago
|
||
Comment on attachment 561949 [details] [diff] [review] github support Looks good! Instead of a gitRepoNames object, you could have a treesInGit array (similar to the existing treesWithGroups array); this would reduce the amount of duplicated data (to just "dxr").
Attachment #561949 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 3•13 years ago
|
||
I updated the patch with your recommendation, so it's a little cleaner. I tested it locally and it's working well. Considering how I don't have commit permissions to mozilla yet, I don't think I can push the patch :(
Attachment #561949 -
Attachment is obsolete: true
Comment 4•13 years ago
|
||
I landed this for you, http://hg.mozilla.org/automation/autolog/rev/cf2fab7a1b7d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•