688673 - Github support for autolog

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Autolog current supports hg repos, but not github ones. Need this functionality for dxr (and potentially other projects?) since development is being done on github.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: github support

This also adds dxr to the list of trees being hosted.

I'm not a fan of the gitRepoNames hack in js/Config.js, since it repeats values that are in repoNames. It's used to check if the repository we're looking at is in git or not, and it's really only used for generating links. The alternative that I was considering was to have two values, hgRepoNames and gitRepoNames, and then just merging the two to be repoNames with jQuery.extend(), since repoNames is used in a few js files for checking which tree we're on, but both solutions sounded icky. Advice?

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 561949 [details] [diff] [review]
github support

Looks good! 

Instead of a gitRepoNames object, you could have a treesInGit array (similar to the existing treesWithGroups array); this would reduce the amount of duplicated data (to just "dxr").

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: github support

I updated the patch with your recommendation, so it's a little cleaner. I tested it locally and it's working well.

Considering how I don't have commit permissions to mozilla yet, I don't think I can push the patch :(

Comment 4

[Jonathan Griffin (:jgriffin)]

I landed this for you, http://hg.mozilla.org/automation/autolog/rev/cf2fab7a1b7d