688681 - Patch for bug 674321 disabled most of our bfcache tests, and probably various other docshell tests

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Backout patch coming up.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Back out and fix an issue with Cc not being defined that prevented the test window from closing

Comment 2

[Boris Zbarsky [:bzbarsky]]

Note to self: we'll need this on Aurora too.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Back out and fix an issue with Cc not being defined that prevented the test window from closing

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

I uploaded a patch to bug 677002 which fixes the chrome tests which use snapshotWindow.

Comment 5

[Boris Zbarsky [:bzbarsky]]

This bug isn't about snapshotWindow....

Comment 6

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/95015f02ddc7

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 561957 [details] [diff] [review]
Back out  and fix an issue with Cc not being defined that prevented the test window from closing

Asking for aurora approval to restore test coverage there.

Comment 8

[Ed Morley [:emorley]]

(In reply to Boris Zbarsky (:bz) from comment #6)
> http://hg.mozilla.org/integration/mozilla-inbound/rev/95015f02ddc7

https://hg.mozilla.org/mozilla-central/rev/95015f02ddc7

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 561957 [details] [diff] [review]
Back out  and fix an issue with Cc not being defined that prevented the test window from closing

approving for beta.

Comment 10

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e9c3ad994064

Comment 11

[u279076]

qa- as nothing to do for QA fix verification -- please set to qa+ if this is not the case.

Comment 12

[Jesse Ruderman]

There are vague plans to make unexpected JS exceptions count as failures (bug 657485, bug 687977).