Closed
Bug 688689
Opened 14 years ago
Closed 13 years ago
New throbber animation for Fennec
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
Firefox 9
People
(Reporter: mbrubeck, Unassigned)
References
Details
Attachments
(2 files)
|
134.33 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
|
14.59 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #679927 +++
Since the two-stage throbber in bug 679927 requires some more code changes, as an initial step we will just replace the current single-stage throbber animation with the new animated icon from that bug.
The first patch just replaces the current throbber icon. We will also need new backgrounds for endcaps on SSL sites that work better with the dark blue color of the new throbber.
Attachment #561964 -
Flags: review?(mark.finkle)
Comment 1•14 years ago
|
||
Comment on attachment 561964 [details] [diff] [review]
part 1: new throbber asset
Did you try pngcrush on the files to remove any cruft?
Attachment #561964 -
Flags: review?(mark.finkle) → review+
| Reporter | ||
Comment 2•14 years ago
|
||
This uses the new endcap assets and colors from bug 679927. It also removes some unused images from the honeycomb theme folder.
All images in both patches have been pngcrushed.
Attachment #562154 -
Flags: review?(mark.finkle)
Updated•14 years ago
|
Attachment #562154 -
Flags: review?(mark.finkle) → review+
| Reporter | ||
Comment 3•14 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e370a64b8d1
https://hg.mozilla.org/integration/mozilla-inbound/rev/96b970e6291b
Whiteboard: [has patch] → [inbound]
| Reporter | ||
Comment 4•14 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/96b970e6291b
https://hg.mozilla.org/mozilla-central/rev/6e370a64b8d1
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
Comment 5•14 years ago
|
||
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110925 Firefox/9.0a1 Fennec/9.0a1
Status: RESOLVED → VERIFIED
| Reporter | ||
Comment 6•14 years ago
|
||
Backed out because of Maemo perf regressions (bug 689578). This can re-land after we verify that it does not regress performance on Android (waiting on bug 689350).
http://hg.mozilla.org/mozilla-central/rev/115e3576acf5
| Reporter | ||
Comment 7•14 years ago
|
||
We did not see similar regressions on Android, but Mark points out that this might be because the Android Tegra machines are dual-core while the Maemo N900 machines are single-core. We need performance tests from single-core Android devices to make sure we are not regressing them.
| Reporter | ||
Updated•13 years ago
|
Assignee: mbrubeck → nobody
Comment 8•13 years ago
|
||
Gone native!
Status: REOPENED → RESOLVED
Closed: 14 years ago → 13 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•