688691 - Add a warning using nsIDocument::WarnOnceAbout when we allow unwrapping to fail silently

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 684671 comment 22.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So what this needs is a way to go from a JSObject to an nsIDocument.  I guess I could get the global and hope it's a Window, but do I want |obj| or |callee| to get the global from?

Comment 2

[Boris Zbarsky [:bzbarsky]]

So I can add this but it will have no property name and no line/stack information... so I'm not sure how useful it will be.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Ah, maybe we'll have useful line info somehow by magic!   That certainly makes this a lot more useful!

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Warn when LenientThis actually causes us to not throw.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 734269 [details] [diff] [review]
Warn when LenientThis actually causes us to not throw.

Review of attachment 734269 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/BindingUtils.cpp
@@ +1691,5 @@
> +void
> +ReportLenientThisUnwrappingFailure(JSContext* cx, JS::Handle<JSObject*> obj)
> +{
> +  GlobalObject glob(cx, obj);
> +  nsCOMPtr<nsPIDOMWindow> win = do_QueryInterface(glob.Get());

Nit: I'd have used 'global' and 'window'.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Done, and https://hg.mozilla.org/integration/mozilla-inbound/rev/729177f4b5c8

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/729177f4b5c8