Closed Bug 688749 Opened 8 years ago Closed 8 years ago

reftest.js will throw an exception if we do a getPref and the pref doesn't exist

Categories

(Testing :: Reftest, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla9

People

(Reporter: jmaher, Assigned: jmaher)

Details

(Whiteboard: [inbound])

Attachments

(1 file, 1 obsolete file)

currently we collect a handful of prefs in the same try/catch block.  We found that ignoreWindowSize was not being set properly due to a missing pref above it. 

We need to split out the get*Pref() calls into separate try/catch blocks.  Also I have added in the reftest.remote flag for the remote test runner.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #562029 - Flags: review?(dbaron)
Thanks, this patch will fix my problem.
Comment on attachment 562029 [details] [diff] [review]
add try/catch statements around all pref calls (1.0)

Assuming that the changes to remotereftest.py were not intended to be part of this patch (since they're writing bad syntax to a prefs file), r=dbaron on the reftest.js changes.
Attachment #562029 - Flags: review?(dbaron) → review+
Comment on attachment 562029 [details] [diff] [review]
add try/catch statements around all pref calls (1.0)

>Bug 688749 - reftest.js will throw an exception if we do a getPref and the pref doesn't exist

Also, your commit message should describe what you're changing, not the old state that you're fixing, so it should instead say something like:

Make reftest.js allow its preferences to be missing (and catch the resulting exceptions).  (Bug 688749)
updated patch to remove the remotereftest.py changes.
Attachment #562029 - Attachment is obsolete: true
Attachment #562699 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/9733c9885c02
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.