688749 - reftest.js will throw an exception if we do a getPref and the pref doesn't exist

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

currently we collect a handful of prefs in the same try/catch block.  We found that ignoreWindowSize was not being set properly due to a missing pref above it. 

We need to split out the get*Pref() calls into separate try/catch blocks.  Also I have added in the reftest.remote flag for the remote test runner.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add try/catch statements around all pref calls (1.0)

Comment 2

[Benoit Girard (:BenWa)]

Thanks, this patch will fix my problem.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 562029 [details] [diff] [review]
add try/catch statements around all pref calls (1.0)

Assuming that the changes to remotereftest.py were not intended to be part of this patch (since they're writing bad syntax to a prefs file), r=dbaron on the reftest.js changes.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 562029 [details] [diff] [review]
add try/catch statements around all pref calls (1.0)

>Bug 688749 - reftest.js will throw an exception if we do a getPref and the pref doesn't exist

Also, your commit message should describe what you're changing, not the old state that you're fixing, so it should instead say something like:

Make reftest.js allow its preferences to be missing (and catch the resulting exceptions).  (Bug 688749)

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add try/catch statements around all pref calls (1.1)

updated patch to remove the remotereftest.py changes.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9733c9885c02

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/9733c9885c02