688783 - Back out bug 641836 to fix keyboard issues until bug 669995 is fixed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

The landing of bug 641836 caused a regression that prevents the keyboard from opening in on Etherpad, Jobvite, and many other sites that use JavaScript to switch focus when a text field is clicked.

We shipped this regression in Firefox 6 and 7 because we didn't realize the extent of the problem in time to back it out.  However, with the increase in Nightly/Aurora users we are seeing a ton of duplicate bugs and finding more sites that this effects.  We should back out bug 641836 until the regression can be fixed.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: backout

This is just a complete backout of bug 641836.  Requesting approval-mozilla-aurora for Firefox 8.  This backs out a change that caused a serious user-visible regression in Firefox 6.  See comment 0 for more discussion.  I believe this is low-risk; it restores the code that we shipped in Firefox 4 and 5.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 562126 [details] [diff] [review]
backout

I agree that backing this out will (hopefully) result in fixing many recently filed keyboard bugs.

The IME code is being rewritten, so hopefully we can address the original bug a little better.

Let's get this on trunk ASAP so we can do some quick tests.

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eadc362c7929

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/eadc362c7929

Comment 5

[Matt Brubeck (:mbrubeck)]

Landed on Beta for Firefox 8:
https://hg.mozilla.org/releases/mozilla-beta/rev/61c8d142f5d3

Comment 6

[Cristian Nicolae (:xti)]

Virtual Keyboard is triggered when opening an Etherpad webpage on the latest Beta build. I'm able to change the name and to chat, but when I tap on the Etherpad body, the Vkb is still displayed, but the cursor is missing. If I hit any character key in this case, nothing is typed on the left side. Should I close this issue as verified fixed?

--
Mozilla/5.0 (Android;Linux armv7l;rv:8.0)Gecko/20110928
Firefox/8.0 Fennec/8.0
Device: Samsung Galaxy S
OS: Android 2.2

Comment 7

[Matt Brubeck (:mbrubeck)]

(In reply to Cristian Nicolae (:xti) from comment #6)
> Virtual Keyboard is triggered when opening an Etherpad webpage on the latest
> Beta build. I'm able to change the name and to chat, but when I tap on the
> Etherpad body, the Vkb is still displayed, but the cursor is missing. If I
> hit any character key in this case, nothing is typed on the left side.
> Should I close this issue as verified fixed?

Yes, please.  File separate bugs (if they are not filed yet) for Etherpad issues other than the keyboard not appearing.

Comment 8

[Camelia Urian]

Based on previous 2 comments, marking as verified fixed.