Closed Bug 688783 Opened 8 years ago Closed 8 years ago

Back out bug 641836 to fix keyboard issues until bug 669995 is fixed

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set

Tracking

(firefox6 wontfix, firefox7 wontfix, firefox8 fixed, firefox9 fixed)

VERIFIED FIXED
Firefox 8
Tracking Status
firefox6 --- wontfix
firefox7 --- wontfix
firefox8 --- fixed
firefox9 --- fixed

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: verified-beta)

Attachments

(1 file)

The landing of bug 641836 caused a regression that prevents the keyboard from opening in on Etherpad, Jobvite, and many other sites that use JavaScript to switch focus when a text field is clicked.

We shipped this regression in Firefox 6 and 7 because we didn't realize the extent of the problem in time to back it out.  However, with the increase in Nightly/Aurora users we are seeing a ton of duplicate bugs and finding more sites that this effects.  We should back out bug 641836 until the regression can be fixed.
Attached patch backoutSplinter Review
This is just a complete backout of bug 641836.  Requesting approval-mozilla-aurora for Firefox 8.  This backs out a change that caused a serious user-visible regression in Firefox 6.  See comment 0 for more discussion.  I believe this is low-risk; it restores the code that we shipped in Firefox 4 and 5.
Attachment #562126 - Flags: review?(mark.finkle)
Attachment #562126 - Flags: approval-mozilla-aurora?
Comment on attachment 562126 [details] [diff] [review]
backout

I agree that backing this out will (hopefully) result in fixing many recently filed keyboard bugs.

The IME code is being rewritten, so hopefully we can address the original bug a little better.

Let's get this on trunk ASAP so we can do some quick tests.
Attachment #562126 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/eadc362c7929
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
Attachment #562126 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
Landed on Beta for Firefox 8:
https://hg.mozilla.org/releases/mozilla-beta/rev/61c8d142f5d3
Target Milestone: Firefox 9 → Firefox 8
Whiteboard: [QA+]
Virtual Keyboard is triggered when opening an Etherpad webpage on the latest Beta build. I'm able to change the name and to chat, but when I tap on the Etherpad body, the Vkb is still displayed, but the cursor is missing. If I hit any character key in this case, nothing is typed on the left side. Should I close this issue as verified fixed?

--
Mozilla/5.0 (Android;Linux armv7l;rv:8.0)Gecko/20110928
Firefox/8.0 Fennec/8.0
Device: Samsung Galaxy S
OS: Android 2.2
Keywords: verified-beta
(In reply to Cristian Nicolae (:xti) from comment #6)
> Virtual Keyboard is triggered when opening an Etherpad webpage on the latest
> Beta build. I'm able to change the name and to chat, but when I tap on the
> Etherpad body, the Vkb is still displayed, but the cursor is missing. If I
> hit any character key in this case, nothing is typed on the left side.
> Should I close this issue as verified fixed?

Yes, please.  File separate bugs (if they are not filed yet) for Etherpad issues other than the keyboard not appearing.
Based on previous 2 comments, marking as verified fixed.
Status: RESOLVED → VERIFIED
Whiteboard: [QA+]
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.