Closed Bug 688897 Opened 14 years ago Closed 13 years ago

REFTEST TEST-UNEXPECTED-FAIL layout/reftests/border-image/470250-2.html | image comparison (==)

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15
Tracking Flags:
Tracking Status
firefox13 --- fixed
firefox14 --- fixed
firefox-esr10 --- fixed

People

(Reporter: graememcc, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [qa-])

Attachments

(2 files)

modify the test to make it more obvious what's going on
1.08 KB, patch
Details | Diff | Splinter Review
fix?
1.05 KB, patch
jrmuizel
: review+
lsblakk
: approval-mozilla-aurora+
lsblakk
: approval-mozilla-beta+
lsblakk
: approval-mozilla-esr10+
Details | Diff | Splinter Review
Seen a couple of instances of this, the first with the unrelated https://hg.mozilla.org/integration/mozilla-inbound/rev/267250a4595e. The image doesn't seem to have rendered when the snapshot is taken. REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/test/build/reftest/tests/layout/reftests/border-image/470250-2.html | image comparison (==) https://tbpl.mozilla.org/php/getParsedLog.php?id=6509644&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=6505853&tree=Mozilla-Inbound
I'm sorry folks, I looked at this a little and I have no idea.
You get a random-if! You get a random-if! Everybody gets random-ifs!
Assignee: nobody → philringnalda
Attached patch fix? — — Splinter Review
Isn't this just a race between loading the border image and the snapshot? Using the same url in an iframe seems to fix that since MozReftestInvalidate waits until all frames are loaded. None of the orange here is for this bug: https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=9f2a8e0d210c
Attachment #622846 - Flags: review?(jmuizelaar)
Ok, maybe we just need the fix from bug 697230
Yeah, I expect bug 697230 will fix this. We can use my patch to wallpaper the orange on branches if desired.
Depends on: 697230
Comment on attachment 622846 [details] [diff] [review] fix? Sure. Though, please add a comment about why we need to do this hack.
Attachment #622846 - Flags: review?(jmuizelaar) → review+
Mats, can you push your fix?
Best effect of taking a bug I've ever had :)
Assignee: philringnalda → nobody
https://hg.mozilla.org/mozilla-central/rev/565d109294a9 Leaving open since wallpaper until bug 697230; close if I've misinterpreted :-)
Target Milestone: --- → mozilla15
Comment on attachment 622846 [details] [diff] [review] fix? [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: none Testing completed (on m-c, etc.): seems to have fixed this orange on trunk Risk to taking this patch (and alternatives if risky): none, only changes a test String or UUID changes made by this patch: none
Attachment #622846 - Flags: approval-mozilla-beta?
Attachment #622846 - Flags: approval-mozilla-aurora?
Comment on attachment 622846 [details] [diff] [review] fix? approving test-only fix.
Attachment #622846 - Flags: approval-mozilla-beta?
Attachment #622846 - Flags: approval-mozilla-beta+
Attachment #622846 - Flags: approval-mozilla-aurora?
Attachment #622846 - Flags: approval-mozilla-aurora+
Blocks: 438871
Depends on: 697230
Attachment #622711 - Flags: review?(wchen)
Comment on attachment 622846 [details] [diff] [review] fix? [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: test-only fix for intermittent orange. User impact if declined: Sheriffs disliking the esr10 tree even more than usual. Fix Landed on Version: trunk+aurora+beta Risk to taking this patch (and alternatives if risky): None, test only. String or UUID changes made by this patch: None See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #622846 - Flags: approval-mozilla-esr10?
Comment on attachment 622846 [details] [diff] [review] fix? test only fix for intermittent oranges, approving for ESR landing.
Attachment #622846 - Flags: approval-mozilla-esr10? → approval-mozilla-esr10+
https://hg.mozilla.org/releases/mozilla-esr10/rev/621ddb28bca0
Status: NEW → RESOLVED
Closed: 13 years ago
status-firefox-esr10: --- → fixed
Resolution: --- → FIXED
Flags: in-testsuite+
Whiteboard: [orange] → [orange][qa-]
Whiteboard: [orange][qa-] → [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: