Closed Bug 688996 Opened 13 years ago Closed 13 years ago

"ASSERTION: Wrong root"

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla10

People

(Reporter: jruderman, Assigned: MatsPalmgren_bugz)

References

Details

(Keywords: assertion, testcase, Whiteboard: [inbound])

Attachments

(4 files, 1 obsolete file)

stack trace
3.36 KB, text/plain
Details
Simpler testcase
367 bytes, text/html
Details
Another test that triggers the same range update using splitText()
291 bytes, text/html
Details
fix+tests, v1
3.36 KB, patch
smaug
: review+
Details | Diff | Splinter Review
Attached file testcase (obsolete) — 
###!!! ASSERTION: Wrong root: '!aRoot || aNotInsertedYet || (nsContentUtils::ContentIsDescendantOf(aStartN, aRoot) && nsContentUtils::ContentIsDescendantOf(aEndN, aRoot) && aRoot == IsValidBoundary(aStartN) && aRoot == IsValidBoundary(aEndN))', file content/base/src/nsRange.cpp, line 524

Maybe a regression from bug 682463?
Attached file stack trace — 

  

  



    
  
Assignee: nobody → matspal
Blocks: 682463
Severity: normal → minor
OS: Mac OS X → All
Hardware: x86_64 → All

    
    

    
  

      
      
      
      

        Attached file
          
        Simpler testcase
        — 
      

    


  

  

  



        Attachment #562257 -
        Attachment is obsolete: true

    
    

    
  


  

  

  



    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix+tests, v1
        — 
          — Splinter Review
      

    


  
Just need to avoid this assertion for newStartNode with null parent too.
Added the attached testcases as crashtests and the splitText() version
to the "splitText-normalize" reftest.

Try server results pending...

  

  



        Attachment #566414 -
        Flags: review?(Olli.Pettay)

        Attachment #566414 -
        Flags: review?(Olli.Pettay) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d5eee785f85

  

  


Flags: in-testsuite+
Whiteboard: [inbound]
Target Milestone: --- → mozilla10

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3d5eee785f85

  

  


Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Component: DOM: Traversal-Range → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: