Closed Bug 689006 Opened 9 years ago Closed 8 years ago

Upgrade pywebsocket to binary API

Categories

(Testing :: Mochitest, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla11

People

(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)

References

Details

Attachments

(1 file, 1 obsolete file)

Upgrade pywebsocket to version 553.

This upgrade is needed to get binary API support in pywebsocket.

I just grabbed the whole pywebsocket tree from scratch, and made our tweaks to it--seems to work fine.

(Patrick: I didn't actually seem to tweak the exception in ConnectionTerminatedException() to get python 2.5 to work--but I'm not sure I hit it at any point.  All our WS mochitests worked fine w/o the change.  I added it in just in case.)

Added a README-MOZILLA file that describes update steps for future reference.

This should also fix bug 688768 (Python > 2.5 support).
Attachment #562271 - Flags: review?(mcmanus)
s/seem to tweak/seem to need to tweak/
> (Patrick: I didn't actually seem to tweak the exception in
> ConnectionTerminatedException() to get python 2.5 to work--but I'm not sure
> I hit it at any point.  All our WS mochitests worked fine w/o the change.  I
> added it in just in case.)
> 

iirc that change was fixing a bug that subsequently was fixed by the pywebsocket authors after I reported it, so it makes sense it might be redundant now. OTOH it might have also been related to deflate-stream support, which I just turned off on nightly. You might turn it on (via pref) to double check it still works. (just turn on the pref and run the same tests.)
Passes try with or without network.websocket.extensions.stream-deflate set, so I guess let's go with the unmodified google version of _stream_base.py
Attachment #562271 - Attachment is obsolete: true
Attachment #562271 - Flags: review?(mcmanus)
Attachment #562365 - Flags: review?(mcmanus)
Comment on attachment 562365 [details] [diff] [review]
v2 Upgrade mochitest pywebsocket server to version 553 (latest)

Review of attachment 562365 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know why, but it breaks the test in 664284 (HSTS) which is something that is a must to merge.
Attachment #562365 - Flags: review?(mcmanus) → review-
Attachment #562365 - Flags: review- → review?(mcmanus)
Patrick: if this still looks good other than the HSTS issue, please +r: the HSTS bug contains the breakage fix on top of this patch (seemed like the logical place to put it).
Attachment #562365 - Flags: review?(mcmanus) → review+
https://hg.mozilla.org/mozilla-central/rev/508b748801b7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Assignee: nobody → jduell.mcbugs
You need to log in before you can comment on or make changes to this bug.