Closed Bug 689025 Opened 10 years ago Closed 10 years ago
Language button has a label referencing location of intl
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110925 Firefox/9.0a1 Fennec/9.0a1 In preferences, the 'Language' button has a label with a value: chrome://global/locale/intl.properties. See screenshot.
My original concern here was when users download and install a locale and then return to the Prefs pane. We don't have a nice language string to show, so instead we fall back to showing the locale code. Apparently when we're using auto-detection that can result in this strangeness? This makes that fallback only happen if the pref has a user set value. Alternatively, instead of listening for pref change notifications, I could fire off an observer notification from the locale picker when "Continue" (or Cancel, etc) was pressed that had the current selected locale name attached.
Attachment #562464 - Flags: review?(mark.finkle)
Comment on attachment 562464 [details] [diff] [review] Patch >- let selectedLocale = Services.prefs.getCharPref("general.useragent.locale"); >+ let selectedLocale = chrome.getSelectedLocale("browser"); >+ // the chrome locale may not have updated yet if the user is installing a new >+ // locale. if the pref has a user set value, use it instead Add a blank line before the comment
Attachment #562464 - Flags: review?(mark.finkle) → review+
Verified fixed on: Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110927 Firefox/9.0a1 Fennec/9.0a1 Device: Acer ICONIA A500 OS: Android 3.1
Status: RESOLVED → VERIFIED
tracking-fennec: ? → -
You need to log in before you can comment on or make changes to this bug.