Closed
Bug 689068
Opened 13 years ago
Closed 8 years ago
[Skia] Fix bug in SkMatrix using SK_Fract1 when using fixed point scalars
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: mattwoodrow, Unassigned)
References
Details
Attachments
(1 file)
|
702 bytes,
patch
|
jrmuizel
:
review-
|
Details | Diff | Splinter Review |
This breaks things pretty badly when using fixed point scalars.
Attachment #562338 -
Flags: review?(jmuizelaar)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 562338 [details] [diff] [review] Use SK_Scalar1 instead The use of SK_Fract1 here seems very intentional. I think we need stronger reasoning as to why it's wrong.
Attachment #562338 -
Flags: review?(jmuizelaar) → review-
|
||
Comment 2•8 years ago
|
||
The affected code no longer exists as of several Skia updates ago.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•