Closed
Bug 689123
Opened 13 years ago
Closed 13 years ago
Add support for Ctrl+A to Message Filters dialog list
Categories
(SeaMonkey :: MailNews: General, enhancement)
SeaMonkey
MailNews: General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)
Details
Attachments
(1 file, 1 obsolete file)
2.73 KB,
patch
|
mnyromyr
:
review+
mnyromyr
:
superreview+
|
Details | Diff | Splinter Review |
In the Message Filters dialog, it would be nice if one could select all tree items using Ctrl+A. This way one can easily deactivate all filters (by pressing Space afterwards) or delete them all (with confirmation). Karsten, please check whether this is OK for Mac or consult Stefan. Also I think this is a MOA case; if you disagree, please forward the sr to Neil.
Attachment #562389 -
Flags: superreview?(mnyromyr)
Attachment #562389 -
Flags: review?(mnyromyr)
Comment 1•13 years ago
|
||
Comment on attachment 562389 [details] [diff] [review] patch >+ else if (String.fromCharCode(event.charCode) == 'a' && event.ctrlKey) First of all, hardcoding a normal key here is bad (and even if it wasn't, you should have checked for KeyEvent.DOM_VK_A anyway). Second, Mac uses the Command key (.metaKey) for such tasks, not ctrl; and other systems may even use something else. The usual way would be using a <key id="key_selectAll"/> with a custom (on)command, which will get the right key definitions through utilityOverlay.xul/platformCommunicatorOverlay.xul.
Attachment #562389 -
Flags: superreview?(mnyromyr)
Attachment #562389 -
Flags: review?(mnyromyr)
Attachment #562389 -
Flags: review-
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #562389 -
Attachment is obsolete: true
Attachment #562684 -
Flags: review?(mnyromyr)
Assignee | ||
Comment 3•13 years ago
|
||
Hmm, seems I missed a semicolon, but I can easily do that when checking in.
Comment 4•13 years ago
|
||
Comment on attachment 562684 [details] [diff] [review] patch v2 [Checkin: comment 5] Yeah, that's it. Just two nits: >+var filterController = >+{ The variable is global and hence should be named gFilterController. >+} And the semicolon you mentioned. ;-) r/moa=me with that. (Tested on both Linux and Mac.)
Attachment #562684 -
Flags: superreview+
Attachment #562684 -
Flags: review?(mnyromyr)
Attachment #562684 -
Flags: review+
Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 562684 [details] [diff] [review] patch v2 [Checkin: comment 5] http://hg.mozilla.org/comm-central/rev/1189f39be20c
Attachment #562684 -
Attachment description: patch v2 → patch v2 [Checkin: comment 5]
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•