689123 - Add support for Ctrl+A to Message Filters dialog list

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, enhancement)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch

In the Message Filters dialog, it would be nice if one could select all tree items using Ctrl+A. This way one can easily deactivate all filters (by pressing Space afterwards) or delete them all (with confirmation).

Karsten, please check whether this is OK for Mac or consult Stefan. Also I think this is a MOA case; if you disagree, please forward the sr to Neil.

Comment 1

[Karsten Düsterloh]

Comment on attachment 562389 [details] [diff] [review]
patch

>+  else if (String.fromCharCode(event.charCode) == 'a' && event.ctrlKey)

First of all, hardcoding a normal key here is bad (and even if it wasn't, you should have checked for KeyEvent.DOM_VK_A anyway).
Second, Mac uses the Command key (.metaKey) for such tasks, not ctrl; and other systems may even use something else.

The usual way would be using a <key id="key_selectAll"/> with a custom (on)command, which will get the right key definitions through utilityOverlay.xul/platformCommunicatorOverlay.xul.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v2 [Checkin: comment 5]

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Hmm, seems I missed a semicolon, but I can easily do that when checking in.

Comment 4

[Karsten Düsterloh]

Comment on attachment 562684 [details] [diff] [review]
patch v2 [Checkin: comment 5]

Yeah, that's it. 

Just two nits:

>+var filterController =
>+{

The variable is global and hence should be named gFilterController.

>+}

And the semicolon you mentioned. ;-)

r/moa=me with that.

(Tested on both Linux and Mac.)

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 562684 [details] [diff] [review]
patch v2 [Checkin: comment 5]

http://hg.mozilla.org/comm-central/rev/1189f39be20c