689128 - crash when calling nsIEventListenerService.getListenerInfoFor with null argument

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[arno renevier]

Hi,
following code in chrome context crashes mozilla:
    Components.classes["@mozilla.org/eventlistenerservice;1"].getService(Ci.nsIEventListenerService).getListenerInfoFor(null, {})

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yeah ... don't do that ;-)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Or we could NS_ENSURE_ARG_POINTER and be done with it.  Might be worth it....

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Not so fun; bug 587698 disabled *all* our event listener service tests, and now
even those ones not using JSD fail because of compartment mismatch, and once that problem is fixed
there is an assertion I don't quite understand yet...

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: WIP

but getEventTargetChainFor call causes still 
###!!! ASSERTION: Non-global object has the wrong flags: '!(jsclazz->flags & JSCLASS_IS_GLOBAL)', file /home/smaug/mozilla/hg/m-c/js/src/xpconnect/src/xpcwrappednative.cpp, line 1146
XPCWrappedNative::Init(XPCCallContext&, JSObject*, int, XPCNativeScriptableCreateInfo const*) (/home/smaug/mozilla/hg/m-c/js/src/xpconnect/src/xpcwrappednative.cpp:1145)

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

So the assertion happens somehow when page's JS touches TabChildGlobal.

I wonder what has changed since bug 587698 to cause that assertion to fire.
(The assertion has been there for a long time)

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/src/xpcconvert.cpp#486 is in the stack..

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Ok, found the problem, patch coming.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

The patch has sort of random stuff that is needed to be able to run the
tests again without errors or assertions.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 565809 [details] [diff] [review]
patch

r=me

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/4c02f4104c17