689161 - Remote testing options somewhat unclear, remote configurator fails strangely when using adb and no device ip set

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[William Lachance (:wlach)]

Attachment: patch to improve documentation + address deviceip issue

As discussed on irc, there's a few things that are a bit strange about configuring remote talos at the moment:

1. You need to specify a device IP even when using adb with a single machine, otherwise it will fail with an obscure error
2. The command line options could be a bit clearer (specifically, after (1) is fixed, you only need to be specify a device ip if using sutagent)

The attached patch addresses both of these issues.

Comment 1

[William Lachance (:wlach)]

Attachment: Updated patch to error when arguments were specified

Here's a small update to the patch to error out when command line arguments are specified. I just realized this was the problem when folowing the instructions here:

http://elvis314.wordpress.com/2010/10/04/talos-remote-testing-and-android/

It looks like wordpress replaced '--' with '–', which caused options to be interpreted as command line arguments, however it wasn't clear that this was actually happening (since talos just ate any options prefixed that way as arguments). The blog entry should prolly be updated to use <pre> for stuff that's meant to be entered into a terminal, but this patch should prevent that sort of gotcha from tripping us up in the future.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 562451 [details] [diff] [review]
Updated patch to error when arguments were specified

Review of attachment 562451 [details] [diff] [review]:
-----------------------------------------------------------------

great, nice simple cleanup

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/rev/fafc5b065d76