Last Comment Bug 689164 - Disable Style Inspector from Highlighter UI
: Disable Style Inspector from Highlighter UI
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: Firefox 9
Assigned To: Rob Campbell [:rc] (:robcee)
:
Mentors:
Depends on: 663831
Blocks: 689160
  Show dependency treegraph
 
Reported: 2011-09-26 08:23 PDT by Rob Campbell [:rc] (:robcee)
Modified: 2011-09-27 04:30 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
[in-fx-team] Disable Style Inspector (1.01 KB, patch)
2011-09-26 08:25 PDT, Rob Campbell [:rc] (:robcee)
mihai.sucan: review+
Details | Diff | Review

Description Rob Campbell [:rc] (:robcee) 2011-09-26 08:23:30 PDT
Ensure that the Style Inspector is disabled in the Highlighter UI until the leaks described in bug 689160 are fixed.
Comment 1 Rob Campbell [:rc] (:robcee) 2011-09-26 08:25:40 PDT
Created attachment 562433 [details] [diff] [review]
[in-fx-team] Disable Style Inspector
Comment 2 Rob Campbell [:rc] (:robcee) 2011-09-26 08:26:56 PDT
Without Patch (and bug 663831 and associates applied):

    --DOMWINDOW == 41 (0x159a29dc8) [serial = 17] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 40 (0x160996bc8) [serial = 22] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 39 (0x1638e9c98) [serial = 28] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 38 (0x1692832c8) [serial = 32] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 37 (0x16b3b3878) [serial = 39] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 36 (0x141850938) [serial = 47] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 35 (0x1072dea18) [serial = 3] [outer = 0x0] [url = chrome://browser/content/hiddenWindow.xul]
    --DOMWINDOW == 34 (0x10723a108) [serial = 1] [outer = 0x0] [url = chrome://browser/content/browser.xul]
    --DOMWINDOW == 33 (0x13ea54148) [serial = 51] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 18 (0x141804848) [serial = 77] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 17 (0x13eaec5b8) [serial = 69] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 16 (0x1418ccec8) [serial = 105] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 15 (0x1418979b8) [serial = 91] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 14 (0x16b3cbcb8) [serial = 100] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 13 (0x16d04e1a8) [serial = 88] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 12 (0x16d04a6f8) [serial = 87] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 11 (0x16b305f78) [serial = 35] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 10 (0x1528c1438) [serial = 54] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 9 (0x16b3c9bb8) [serial = 59] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 8 (0x1609d0a08) [serial = 23] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 7 (0x141861c78) [serial = 48] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 6 (0x16d71aa38) [serial = 29] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 5 (0x141ec8268) [serial = 18] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 4 (0x12cd95908) [serial = 13] [outer = 0x0] [url = about:blank]
    --DOMWINDOW == 3 (0x16b3df1a8) [serial = 57] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 2 (0x16b3bb048) [serial = 40] [outer = 0x0] [url = chrome://browser/content/csshtmltree.xhtml]
    --DOMWINDOW == 1 (0x1072e1c58) [serial = 4] [outer = 0x0] [url = chrome://browser/content/hiddenWindow.xul]
    --DOMWINDOW == 0 (0x107246058) [serial = 2] [outer = 0x0] [url = about:blank] 

With patch applied:

--DOCSHELL 0x12a840160 == 2
--DOMWINDOW == 11 (0x12cff4498) [serial = 14] [outer = 0x12ccb4770] [url = about:blank]
--DOMWINDOW == 10 (0x12cf57c18) [serial = 10] [outer = 0x12a8c5e00] [url = about:blank]
--DOMWINDOW == 9 (0x12a8c5e78) [serial = 6] [outer = 0x0] [url = about:blank]
--DOMWINDOW == 8 (0x12cf2fdf8) [serial = 9] [outer = 0x12a8ae3e0] [url = about:blank]
--DOMWINDOW == 7 (0x12a8ae458) [serial = 5] [outer = 0x0] [url = about:blank]
Comment 3 Mihai Sucan [:msucan] 2011-09-26 09:39:46 PDT
Comment on attachment 562433 [details] [diff] [review]
[in-fx-team] Disable Style Inspector

Review of attachment 562433 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks fine. All tests pass locally.
Comment 4 Rob Campbell [:rc] (:robcee) 2011-09-26 10:42:48 PDT
Comment on attachment 562433 [details] [diff] [review]
[in-fx-team] Disable Style Inspector

https://hg.mozilla.org/integration/fx-team/rev/381904af2863
Comment 5 Tim Taubert [:ttaubert] 2011-09-27 04:30:42 PDT
https://hg.mozilla.org/mozilla-central/rev/381904af2863

Note You need to log in before you can comment on or make changes to this bug.