nsLocalFileUnix.cpp:1432:78: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

RESOLVED FIXED in mozilla9

Status

Core Graveyard
File Handling
RESOLVED FIXED
6 years ago
10 months ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla9
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Filing bug on this build warning:
> xpcom/io/nsLocalFileUnix.cpp:1432:78: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

That points to this line:
> 1432         for (int i = 0; i < NS_ARRAY_LENGTH(executableExts); i++) {
which was added in this cset for bug 663899:
https://hg.mozilla.org/mozilla-central/rev/83c0640ea8b1

Patch coming up.
(Assignee)

Comment 1

6 years ago
Created attachment 562462 [details] [diff] [review]
fix: s/int/size_t/
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #562462 - Flags: review?(smichaud)
Comment on attachment 562462 [details] [diff] [review]
fix: s/int/size_t/

Thanks for catching this.
Attachment #562462 - Flags: review?(smichaud) → review+
Good catch! I wasn't thinking of it at the time.
(Assignee)

Comment 4

6 years ago
Thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/95a1d14917c4
Whiteboard: [inbound]
Target Milestone: --- → mozilla9

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/95a1d14917c4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [inbound]
Blocks: 704622
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.