689195 - nsLocalFileUnix.cpp:1432:78: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Daniel Holbert [:dholbert]]

Filing bug on this build warning:
> xpcom/io/nsLocalFileUnix.cpp:1432:78: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

That points to this line:
> 1432         for (int i = 0; i < NS_ARRAY_LENGTH(executableExts); i++) {
which was added in this cset for bug 663899:
https://hg.mozilla.org/mozilla-central/rev/83c0640ea8b1

Patch coming up.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix: s/int/size_t/

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 562462 [details] [diff] [review]
fix: s/int/size_t/

Thanks for catching this.

Comment 3

[Cameron Kaiser [:spectre]]

Good catch! I wasn't thinking of it at the time.

Comment 4

[Daniel Holbert [:dholbert]]

Thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/95a1d14917c4

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/95a1d14917c4