Last Comment Bug 689195 - nsLocalFileUnix.cpp:1432:78: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
: nsLocalFileUnix.cpp:1432:78: warning: comparison between signed and unsigned ...
Status: RESOLVED FIXED
:
Product: Core Graveyard
Classification: Graveyard
Component: File Handling (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Daniel Holbert [:dholbert]
:
Mentors:
Depends on:
Blocks: buildwarning 663899 704622
  Show dependency treegraph
 
Reported: 2011-09-26 10:01 PDT by Daniel Holbert [:dholbert]
Modified: 2016-06-22 12:16 PDT (History)
2 users (show)
emorley: in‑testsuite-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
fix: s/int/size_t/ (1.15 KB, patch)
2011-09-26 10:04 PDT, Daniel Holbert [:dholbert]
smichaud: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2011-09-26 10:01:29 PDT
Filing bug on this build warning:
> xpcom/io/nsLocalFileUnix.cpp:1432:78: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

That points to this line:
> 1432         for (int i = 0; i < NS_ARRAY_LENGTH(executableExts); i++) {
which was added in this cset for bug 663899:
https://hg.mozilla.org/mozilla-central/rev/83c0640ea8b1

Patch coming up.
Comment 1 Daniel Holbert [:dholbert] 2011-09-26 10:04:54 PDT
Created attachment 562462 [details] [diff] [review]
fix: s/int/size_t/
Comment 2 Steven Michaud [:smichaud] (Retired) 2011-09-26 10:08:22 PDT
Comment on attachment 562462 [details] [diff] [review]
fix: s/int/size_t/

Thanks for catching this.
Comment 3 Cameron Kaiser [:spectre] 2011-09-26 13:49:04 PDT
Good catch! I wasn't thinking of it at the time.
Comment 4 Daniel Holbert [:dholbert] 2011-09-26 15:01:53 PDT
Thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/95a1d14917c4
Comment 5 Ed Morley [:emorley] 2011-09-27 03:37:28 PDT
https://hg.mozilla.org/mozilla-central/rev/95a1d14917c4

Note You need to log in before you can comment on or make changes to this bug.