689253 - Add en-GB locale to Firefox for Android

Status: RESOLVED FIXED

(Mozilla Localizations :: en-GB / English (United Kingdom), defect)

Description

[Ian Neal]

Attachment: Add en-GB for mobile

This patch adds en-GB locale for Mobile 8.0

Comment 1

[Mark Tyndall]

Comment on attachment 562514 [details] [diff] [review]
Add en-GB for mobile

Review of attachment 562514 [details] [diff] [review]:
-----------------------------------------------------------------

mobile/chrome/region.properties may need r/a by stas

mobile/searchplugins/* may be incorrect. For normal Fx, .xml files matching the en-US files aren't required (ie google, twitter, wikipedia), and for the others, en-GB versions should be used.
See <http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-GB/file/fbe1ea1ded8a/browser/searchplugins> for the amazon-en-GB and yahoo-en-GB.

Setting feedback flag for stas for the plugins and region.properties.

r=me with the remaining nits.

::: mobile/chrome/browser.dtd
@@ +39,5 @@
> +<!ENTITY addonsUpdate.label        "Update">
> +<!ENTITY addonsRepo.label          "Get Add-ons">
> +<!ENTITY addonsRecommended.label   "Recommended">
> +<!ENTITY addonsSearch.label        "Search">
> +<!ENTITY addonsSearch2.emptytext   "Search Catalog">

Catalogue would be preferred.

::: mobile/chrome/overrides/appstrings.properties
@@ +48,5 @@
> +unknownSocketType=Firefox doesn't know how to communicate with the server.
> +netReset=The connection to the server was reset while the page was loading.
> +netOffline=Firefox is currently in offline mode and can't browse the Web.
> +isprinting=The document cannot change while Printing or in Print Preview.
> +deniedPortAccess=This address uses a network port which is normally used for purposes other than Web browsing. Firefox has canceled the request for your protection.

canceled -> cancelled

::: mobile/chrome/sync.properties
@@ +1,4 @@
> +# Mobile Sync
> +
> +# %S is the date and time at which the last sync successfully completed
> +lastSync2.label=Last sync: %S

synchronisation

@@ +1,5 @@
> +# Mobile Sync
> +
> +# %S is the date and time at which the last sync successfully completed
> +lastSync2.label=Last sync: %S
> +lastSyncInProgress2.label=Last sync: in progress…

synchronisation

Comment 2

[Staś Małolepszy :stas]

Milos, can you take a look at this as I will be on vacation for the next few days?  Thanks!

Comment 3

[Ian Neal]

Attachment: Add en-GB for mobile v1.1

Address review points and updated to current comm-aurora (Firefox 10.0). Carrying forwards r= and f?

Comment 4

[Axel Hecht [:Pike]]

FYI: I don't see us shipping another localization before we're on the new single-locale scheme with fennec 11.

Comment 5

[Ian Neal]

Attachment: Add en-GB to Firefox for Android 17

Revised patch for current l10n for aurora

Comment 6

[Ian Neal]

Attachment: Add en-GB to Firefox for Android 17 v1.1 [Checked in: Comment 10]

Fixed missing change canceled -> cancelled

Can port to Android 16 if required.

Comment 7

[Staś Małolepszy :stas]

Comment on attachment 659555 [details] [diff] [review]
Add en-GB to Firefox for Android 17 v1.1 [Checked in: Comment 10]

I'll leave it to Milos to provide the feedback on this patch.

Comment 8

[Milos Dinic [:Milos]]

Comment on attachment 659555 [details] [diff] [review]
Add en-GB to Firefox for Android 17 v1.1 [Checked in: Comment 10]

Reassigning to Axel, as I don't do much mobile these days.

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 659555 [details] [diff] [review]
Add en-GB to Firefox for Android 17 v1.1 [Checked in: Comment 10]

Review of attachment 659555 [details] [diff] [review]:
-----------------------------------------------------------------

productization pieces look good. We're still struggling to add new locales to android, though.

Comment 10

[Ian Neal]

Comment on attachment 659555 [details] [diff] [review]
Add en-GB to Firefox for Android 17 v1.1 [Checked in: Comment 10]

http://hg.mozilla.org/releases/l10n/mozilla-beta/en-GB/rev/b965f66b8e0c
http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-GB/rev/a881fb7eee2c

Comment 11

[Axel Hecht [:Pike]]

Hi Ian, sorry for the lag.

We're much better in terms of technical infrastructure on Android, and would like to add en-GB.

How's the current status looking?

Comment 12

[Ian Neal]

compare-locales against current mozilla-beta for both mobile and android show that no strings need translating, so status is looking good.
I will be doing the relevant translations for aurora in the next few days hopefully.
I presume the l10n dashboard will show the tree status once it is added?

Comment 13

[Axel Hecht [:Pike]]

Exactly. I think we should start with adding to all-locales on aurora, and do the multi-locale after that. Thanks for your patience.

Comment 14

[Ian Neal]

(In reply to Axel Hecht [:Pike] from comment #13)
> Exactly. I think we should start with adding to all-locales on aurora, and
> do the multi-locale after that. Thanks for your patience.

Current en-GB aurora has just had relevant strings checked in via bug 880964, so should be ready to be added.

Comment 15

[Ian Neal]

Comment on attachment 659555 [details] [diff] [review]
Add en-GB to Firefox for Android 17 v1.1 [Checked in: Comment 10]

Done and dusted.

Comment 16

[Jeff Beatty [:gueroJeff]]

(In reply to Ian Neal from comment #15)
> Comment on attachment 659555 [details] [diff] [review]
> Add en-GB to Firefox for Android 17 v1.1 [Checked in: Comment 10]
> 
> Done and dusted.

Hi Ian,

Have you had a chance to update Aurora this cycle? It would be great to translate and sign-off within the next two weeks. This will allow us to include en-GB in the Fx 24 multilocale build.

Thanks,
Jeff

Comment 17

[Ian Neal]

(In reply to jbeatty from comment #16)
> (In reply to Ian Neal from comment #15)
> > Comment on attachment 659555 [details] [diff] [review]
> > Add en-GB to Firefox for Android 17 v1.1 [Checked in: Comment 10]
> > 
> > Done and dusted.
> 
> Hi Ian,
> 
> Have you had a chance to update Aurora this cycle? It would be great to
> translate and sign-off within the next two weeks. This will allow us to
> include en-GB in the Fx 24 multilocale build.
> 
> Thanks,
> Jeff

Relevant patches checked into aurora and sign-off has been submitted.

Comment 18

[Jeff Beatty [:gueroJeff]]

(In reply to Ian Neal from comment #17)
> (In reply to jbeatty from comment #16)
> > (In reply to Ian Neal from comment #15)
> > > Comment on attachment 659555 [details] [diff] [review]
> > > Add en-GB to Firefox for Android 17 v1.1 [Checked in: Comment 10]
> > > 
> > > Done and dusted.
> > 
> > Hi Ian,
> > 
> > Have you had a chance to update Aurora this cycle? It would be great to
> > translate and sign-off within the next two weeks. This will allow us to
> > include en-GB in the Fx 24 multilocale build.
> > 
> > Thanks,
> > Jeff
> 
> Relevant patches checked into aurora and sign-off has been submitted.

Fantastic! Thanks Ian!

Congratulations everyone! Thank you all for your hard work and effort!