The default bug view has changed. See this FAQ.

Layout problems and "this.control is undefined" because prefs-uilanguage should not be type="menulist"

VERIFIED FIXED in Firefox 9

Status

Fennec Graveyard
General
VERIFIED FIXED
6 years ago
3 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

({regression})

Firefox 9
Firefox 9
regression
Dependency tree / graph

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 562521 [details] [diff] [review]
patch

Steps to reproduce:
1. Open the Fennec preferences.

Expected results: "Language" label and button are on the same line.
Actual results: "Language" label and button are on separate lines, and the following console errors appear:

reference to undefined property this.getElementsByTagName(this.getAttribute("type") == "radio" ? "radiogroup" : "menulist")[0]
chrome://mozapps/content/extensions/setting.xml
539
this.control is undefined
chrome://mozapps/content/extensions/setting.xml
492

This error was caused by a combination of bug 669390 and bug 658278.  Since this preference no longer contains a menulist, it should use the generic type="control" instead.
Attachment #562521 - Flags: review?(wjohnston)
(Assignee)

Updated

6 years ago
OS: Linux → All
Hardware: x86 → All
Version: Trunk → Firefox 9
Attachment #562521 - Flags: review?(wjohnston) → review+
(Assignee)

Comment 1

6 years ago
https://hg.mozilla.org/mozilla-central/rev/b71570ffc968
Assignee: nobody → mbrubeck
Status: NEW → RESOLVED
Last Resolved: 6 years ago
status-firefox9: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9

Comment 2

6 years ago
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a2)Gecko/20110929
Firefox/9.0a2 Fennec/9.0a2
Device: HTC Desire Z
OS: Android 2.3

Language and language button are displayed on same line and error from comment 1 is not displayed in the error console.
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.