Closed Bug 689267 Opened 8 years ago Closed 8 years ago

Layout problems and "this.control is undefined" because prefs-uilanguage should not be type="menulist"

Categories

(Firefox for Android Graveyard :: General, defect)

Firefox 9
defect
Not set

Tracking

(firefox8 unaffected, firefox9 fixed)

VERIFIED FIXED
Firefox 9
Tracking Status
firefox8 --- unaffected
firefox9 --- fixed

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch patchSplinter Review
Steps to reproduce:
1. Open the Fennec preferences.

Expected results: "Language" label and button are on the same line.
Actual results: "Language" label and button are on separate lines, and the following console errors appear:

reference to undefined property this.getElementsByTagName(this.getAttribute("type") == "radio" ? "radiogroup" : "menulist")[0]
chrome://mozapps/content/extensions/setting.xml
539
this.control is undefined
chrome://mozapps/content/extensions/setting.xml
492

This error was caused by a combination of bug 669390 and bug 658278.  Since this preference no longer contains a menulist, it should use the generic type="control" instead.
Attachment #562521 - Flags: review?(wjohnston)
OS: Linux → All
Hardware: x86 → All
Version: Trunk → Firefox 9
Attachment #562521 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/b71570ffc968
Assignee: nobody → mbrubeck
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a2)Gecko/20110929
Firefox/9.0a2 Fennec/9.0a2
Device: HTC Desire Z
OS: Android 2.3

Language and language button are displayed on same line and error from comment 1 is not displayed in the error console.
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.