689285 - [[ThrowTypeError]] should not be extensible

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

Don't ask me how I missed this when implementing [[ThrowTypeError]]; I have no idea.

Comment 1

[Luke Wagner [:luke]]

Comment on attachment 562529 [details] [diff] [review]
Patch

Review of attachment 562529 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/GlobalObject.cpp
@@ +226,2 @@
>      JSFunction *throwTypeError = js_NewFunction(cx, NULL, ThrowTypeError, 0, 0, this, NULL);
> +    if (!throwTypeError || !throwTypeError->preventExtensions(cx, &ids))

Maybe I'm a nazi, but I'd rather have the AutiIdVector decl after the null check for throwTypeError (and named 'noIds' rather than 'ids').

Comment 2

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ed95d68c0f85

<insert some completely outrageous comment about nazis getting results, for some definition of results>

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

You know who really got results? Commie-nazis!

http://www.youtube.com/watch?v=_g6ctonQoGA

(Although I think after that, McBain kills them with his bare hands.)

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ed95d68c0f85