Last Comment Bug 689285 - [[ThrowTypeError]] should not be extensible
: [[ThrowTypeError]] should not be extensible
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-26 14:00 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-09-27 03:35 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.66 KB, patch)
2011-09-26 14:00 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
luke: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2011-09-26 14:00:49 PDT
Created attachment 562529 [details] [diff] [review]
Patch

Don't ask me how I missed this when implementing [[ThrowTypeError]]; I have no idea.
Comment 1 Luke Wagner [:luke] 2011-09-26 14:07:11 PDT
Comment on attachment 562529 [details] [diff] [review]
Patch

Review of attachment 562529 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/GlobalObject.cpp
@@ +226,2 @@
>      JSFunction *throwTypeError = js_NewFunction(cx, NULL, ThrowTypeError, 0, 0, this, NULL);
> +    if (!throwTypeError || !throwTypeError->preventExtensions(cx, &ids))

Maybe I'm a nazi, but I'd rather have the AutiIdVector decl after the null check for throwTypeError (and named 'noIds' rather than 'ids').
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2011-09-26 16:46:07 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/ed95d68c0f85

<insert some completely outrageous comment about nazis getting results, for some definition of results>
Comment 3 Bill McCloskey (:billm) 2011-09-26 16:54:45 PDT
You know who really got results? Commie-nazis!

http://www.youtube.com/watch?v=_g6ctonQoGA

(Although I think after that, McBain kills them with his bare hands.)
Comment 4 Ed Morley [:emorley] 2011-09-27 03:35:50 PDT
https://hg.mozilla.org/mozilla-central/rev/ed95d68c0f85

Note You need to log in before you can comment on or make changes to this bug.