[[ThrowTypeError]] should not be extensible

RESOLVED FIXED in mozilla9

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

Trunk
mozilla9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 562529 [details] [diff] [review]
Patch

Don't ask me how I missed this when implementing [[ThrowTypeError]]; I have no idea.
Attachment #562529 - Flags: review?(luke)

Comment 1

6 years ago
Comment on attachment 562529 [details] [diff] [review]
Patch

Review of attachment 562529 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/GlobalObject.cpp
@@ +226,2 @@
>      JSFunction *throwTypeError = js_NewFunction(cx, NULL, ThrowTypeError, 0, 0, this, NULL);
> +    if (!throwTypeError || !throwTypeError->preventExtensions(cx, &ids))

Maybe I'm a nazi, but I'd rather have the AutiIdVector decl after the null check for throwTypeError (and named 'noIds' rather than 'ids').
Attachment #562529 - Flags: review?(luke) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/ed95d68c0f85

<insert some completely outrageous comment about nazis getting results, for some definition of results>
Target Milestone: --- → mozilla9
You know who really got results? Commie-nazis!

http://www.youtube.com/watch?v=_g6ctonQoGA

(Although I think after that, McBain kills them with his bare hands.)

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/ed95d68c0f85
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.