Closed Bug 689337 Opened 13 years ago Closed 12 years ago

Desktop notification interfaces should not be marked 'function'

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12

People

(Reporter: khuey, Assigned: Ms2ger)

Details

Attachments

(1 file)

Patch v1
1.13 KB, patch
khuey
: review+
Details | Diff | Splinter Review 
      No description provided.
why?
Because 'function' means you can pass in a JS function and XPConnect will coerce it into the interface.  Both these interfaces are only implemented in C++, so this is unnecessary.
yes, 'function' should be removed.
Assignee: nobody → doug.turner
i am not working on these right now.  resetting assignee.
Assignee: doug.turner → nobody
Attached patch Patch v1 — — Splinter Review 
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED

        Attachment #588344 -
        Flags: review?(khuey)

        Attachment #588344 -
        Flags: review?(khuey) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/0e4cd20fd801
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Version: unspecified → Trunk
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: