Last Comment Bug 689432 - Disambiguate use of "samples" by introducing "frames" in a number of places
: Disambiguate use of "samples" by introducing "frames" in a number of places
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla10
Assigned To: Matthew Gregan [:kinetik]
:
Mentors:
Depends on:
Blocks: cubeb
  Show dependency treegraph
 
Reported: 2011-09-26 20:30 PDT by Matthew Gregan [:kinetik]
Modified: 2011-09-28 02:12 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v0 (97.71 KB, patch)
2011-09-26 20:33 PDT, Matthew Gregan [:kinetik]
cajbir.bugzilla: review+
Details | Diff | Review

Description Matthew Gregan [:kinetik] 2011-09-26 20:30:27 PDT

    
Comment 1 Matthew Gregan [:kinetik] 2011-09-26 20:33:38 PDT
Created attachment 562651 [details] [diff] [review]
patch v0

Refer to "frames" rather than "samples" in most places, so it's clearer which one is really meant.  This is mostly a rename patch, but there are a couple of small logic changes where samples need to be calculated instead of frames.

Also renames ns{Local,Remote}AudioStream to ns{Native,Remoted}AudioStream to make their purpose clearer.
Comment 2 Matthew Gregan [:kinetik] 2011-09-27 20:30:41 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/89b5ec4cacc1
Comment 3 Marco Bonardo [::mak] 2011-09-28 02:12:59 PDT
https://hg.mozilla.org/mozilla-central/rev/89b5ec4cacc1

Note You need to log in before you can comment on or make changes to this bug.