689494 - [Tablet] Pages and top screen UI change size when trying to drag the tab sidebar rightward

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Cristian Nicolae (:xti)]

Attachment: screenshot

Build ID: Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1

Steps to reproduce:
1. Open Fennec App
2. Switch tablet orientation to landscape
3. Perform a pan-to-right action on Tab Panel's area

Expected result:
Nothing should happen.

Actual result:
The webpage and the top UI are moving beyond of the right display edge.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

More details:

Try dragging the tab sidebar to the right. As you are dragging, the web content and actionbar are moved too. When you release the drag, the web content and actionbar snap back to the correct location.

Comment 2

[Matt Brubeck (:mbrubeck)]

This is intentional.  When you grab the sidebar to drag it (in landscape tablet mode), the web page and toolbar resize once before the drag starts, so they won't need to resize as you drag.  Then when you drag to hide the sidebar, the web page and toolbar already have the correct size.  (Resizing as you drag would be better *if* we could do it smoothly, but in practice it is too slow and jerky.)

Resolving this as WONTFIX for now, though we can reopen it if there's a solution that allows us to fix this while still allowing reasonably smooth dragging.

Comment 3

[Matt Brubeck (:mbrubeck)]

We can fix this so the resize only happens when you drag left, not rightward as in comment 1.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: do not alter the UI width when panning depending on the locale

The patch prevent the content width to change when panning to the right only for ltr UI. (And the invert for the rtl).

As soon as you start to pan right the tabbar will be dragged away.

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ae3e1279d98

Comment 6

[Michael Wu [:mwu]]

https://hg.mozilla.org/mozilla-central/rev/0ae3e1279d98

Comment 7

[Carla Nadastean]

Retested with:
Build ID: Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20111020
Firefox/10.0a1 Fennec/10.0a1
Device: Acer ICONIA A500
OS: Android 3.1

Bug is no longer reproducible. Verifying.