Closed Bug 689544 Opened 14 years ago Closed 4 years ago

Improve the nsIMessenger::OpenAttachment interface and back-end code to avoid unnecessary nsString to char* conversions

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr91 wontfix)

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
thunderbird_esr91 --- wontfix

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Bug 689544 - Change nsIMsgMessageService:OpenAttachment to handle UTF8 strings to allow it to be called direct from JS. r?mkmelin!
48 bytes, text/x-phabricator-request
Details | Review
I was originally doing this in bug 684481, but we needed to land the crash fix before the merge point. There's some interfaces and code that can be tided up - xref attachment 562425 [details] [diff] [review]. These need some review comments addressing, see bug 684481 comment 9.

This also avoids unnecessary nsCString -> char* -> nsCString conversions.

Assignee: nobody → standard8
Status: NEW → ASSIGNED
status-thunderbird_esr91: --- → wontfix
Keywords: checkin-needed-tb
Target Milestone: --- → 95 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/6c7a17602297
Change nsIMsgMessageService:OpenAttachment to handle UTF8 strings to allow it to be called direct from JS. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: