689596 - android talos doesn't have a proxy server

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

it appears that we were not running a network http proxy while running talos for android/tegra.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add network proxy to remote.config (1.0)

tested locally, would like to see in staging if we agree on this patch.

Comment 2

[alice nodelman [:alice] [:anode]]

Split seems pretty fragile for this use, I think that you should look into urlparse for something that will provide better error messaging.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

urlparse is helpful, but there are a lot of corner cases with it....let me see if I can find something better.  urlparse also doesn't split out the host:port, hmm.

Comment 4

[alice nodelman [:alice] [:anode]]

My reading of the doc (http://docs.python.org/library/urlparse.html) suggests that it understands port numbers in urls.  Maybe I just haven't hit the right corner case yet. :)

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add network proxy to remote.config (2.0)

updated with urlparse.

Comment 6

[alice nodelman [:alice] [:anode]]

Since you already know the failure state, let's get this wrapped in a try:

+        #NOTE: if server has a scheme, this will fail, as well as the user_pref below will.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

well the error is more like this:
if (server.startswith('http') or server.startswith('chrome') or server.startswith('file') or ...):
  urlparse(server)
else:
  urlparse('http://' + server)


there is no try/except thrown, it is just that we could get into a corner case where the hostname is the original scheme (i.e. http:), so would you be fine adding a check in both places for all types of schemes in the server variable?

fwiw, we have assumed there is no scheme on the webserver since this was originally developed (Nov 2009) and have never had a problem.  I agree we should clean up the code correctly, it is just a lot of parameter checking.  I also cannot assume that we will run perfconfigurator+run_tests without editing the intermediate config file.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add network proxy to remote.config (3.0)

Comment 9

[William Lachance (:wlach)]

Comment on attachment 564841 [details] [diff] [review]
add network proxy to remote.config (3.0)

Review of attachment 564841 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/rev/0b4af7b42197