Closed
Bug 689615
Opened 14 years ago
Closed 12 years ago
string as first argument of setTimeout throw an exception in content script
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: ochameau, Assigned: zombie)
References
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
Currently, if we try to use setTimeout in a content script with a string instead of a function, we receive this incomprehensible exception:
Traceback (most recent call last):
File "resource://jid1-9krhwinmiaqbia-at-jetpack-api-utils-lib/content/worker.js", line 108, in
callback.apply(null, params);
TypeError: callback.apply is not a function
We should at least throw a meaningfull message or implement string.
Reporter | ||
Updated•14 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Priority: -- → P2
Blocks: 692539
Updated•12 years ago
|
Whiteboard: [good first bug]
Comment 1•12 years ago
|
||
I cannot reproduce this.
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #828220 -
Flags: review?(jsantell)
Comment 3•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/c3a26bd603a36407481cbf19925333fd15fd715e
bug 689615 - setTimeout works with string arg.
and some tests too..
https://github.com/mozilla/addon-sdk/commit/004a50706f2f4333359470249b7393f226f2dad5
Merge pull request #1283 from zombie/689615-setTimeout-str-arg
fix bug 689615 - setTimeout works with string arg. r=@jsantell
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Assignee: poirot.alex → tomica+amo
Updated•12 years ago
|
Attachment #828220 -
Flags: review?(jsantell) → review+
Assignee | ||
Updated•11 years ago
|
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•