689675 - crash-stats.mozilla.com XSS

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Ervis Tusha]

https://crash-stats.mozilla.com/products/Firefox/versions/6.0.2/topchangers?duration=3"%2f%3E%3Cimg src=x onerror="alert(1)

Comment 1

[Lonnen :lonnen]

https://github.com/mozilla/socorro/pull/48

PHP's in_array function was erroneously returning true. The string started with an integer that was in the array of integers, and in converting it during the compare something happens to make it evaluate true. We then return the non-converted value.

This will patch it by explicitly converting to an integer beforehand, and then returning the converted value (now just the integer, without the characters following it).

Brandon: r?

Comment 2

[Brandon Savage [:brandon]]

Lonnen: r+ and merged.

https://github.com/mozilla/socorro/commit/38ae94a172d8a0139afe3699b2778931c69e6d6f

Comment 3

[Ervis Tusha]

crash-stats.mozilla.com still vulnerable

Comment 4

[Robert Helmer [:rhelmer]]

minor syntax error (see crash-stats-dev), r? anyone:
https://github.com/mozilla/socorro/pull/49

(we should add a PHP linter to the jenkins steps :))

Comment 5

[Robert Helmer [:rhelmer]]

(In reply to Ervis Tusha from comment #3)
> crash-stats.mozilla.com still vulnerable

This will go live on crash-stats-dev.allizom.org automatically once landed (which resolving the bug signals) until we do a production release. Before a production release, QA will test on stage and mark "verified".

There will be a "push bug" for 2.3 (or whatever milestone the bug is set to) which will be used to track pushing it to production.

Comment 6

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #4)
> minor syntax error (see crash-stats-dev), r? anyone:
> https://github.com/mozilla/socorro/pull/49
> 
> (we should add a PHP linter to the jenkins steps :))

This is blocking QA, and I tested locally so merging myself (the XSS from comment 0 seems resolved btw).

https://github.com/mozilla/socorro/commit/e2424ec77cdcbc73cd74a5af91e8678383e3706c

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats-dev.allizom.org/products/Firefox/versions/6.0.2/topchangers?duration=3%22%2f%3E%3Cimg%20src=x%20onerror=%22alert%281%29

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

I think we could write a test for this; use urllib to verify that the URL returns a 200 OK, without an alert.