crash-stats.mozilla.com XSS

VERIFIED FIXED in 2.2.5

Status

Socorro
Webapp
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: Ervis Tusha, Assigned: lonnen)

Tracking

Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
https://crash-stats.mozilla.com/products/Firefox/versions/6.0.2/topchangers?duration=3"%2f%3E%3Cimg src=x onerror="alert(1)
(Reporter)

Updated

6 years ago
Hardware: x86_64 → All
(Reporter)

Updated

6 years ago
Component: Your Web → Other

Updated

6 years ago
Target Milestone: --- → 2.3
(Assignee)

Updated

6 years ago
Assignee: nobody → chris.lonnen
(Assignee)

Comment 1

6 years ago
https://github.com/mozilla/socorro/pull/48

PHP's in_array function was erroneously returning true. The string started with an integer that was in the array of integers, and in converting it during the compare something happens to make it evaluate true. We then return the non-converted value.

This will patch it by explicitly converting to an integer beforehand, and then returning the converted value (now just the integer, without the characters following it).

Brandon: r?
Lonnen: r+ and merged.

https://github.com/mozilla/socorro/commit/38ae94a172d8a0139afe3699b2778931c69e6d6f
Status: UNCONFIRMED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

6 years ago
crash-stats.mozilla.com still vulnerable
minor syntax error (see crash-stats-dev), r? anyone:
https://github.com/mozilla/socorro/pull/49

(we should add a PHP linter to the jenkins steps :))
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: FIXED → ---
(In reply to Ervis Tusha from comment #3)
> crash-stats.mozilla.com still vulnerable

This will go live on crash-stats-dev.allizom.org automatically once landed (which resolving the bug signals) until we do a production release. Before a production release, QA will test on stage and mark "verified".

There will be a "push bug" for 2.3 (or whatever milestone the bug is set to) which will be used to track pushing it to production.
(In reply to Robert Helmer [:rhelmer] from comment #4)
> minor syntax error (see crash-stats-dev), r? anyone:
> https://github.com/mozilla/socorro/pull/49
> 
> (we should add a PHP linter to the jenkins steps :))

This is blocking QA, and I tested locally so merging myself (the XSS from comment 0 seems resolved btw).

https://github.com/mozilla/socorro/commit/e2424ec77cdcbc73cd74a5af91e8678383e3706c
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Blocks: 690146
Group: websites-security → webtools-security
Component: Other → Socorro
Product: Websites → Webtools
QA Contact: yourweb → socorro
Target Milestone: 2.3 → 2.2.5
Version: unspecified → 2.2
Created attachment 563258 [details]
Post-fix screenshot
Verified FIXED on https://crash-stats-dev.allizom.org/products/Firefox/versions/6.0.2/topchangers?duration=3%22%2f%3E%3Cimg%20src=x%20onerror=%22alert%281%29
Status: RESOLVED → VERIFIED
I think we could write a test for this; use urllib to verify that the URL returns a 200 OK, without an alert.
Flags: in-testsuite?
Group: webtools-security
Component: Socorro → General
Product: Webtools → Socorro
Component: General → Webapp
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.