https://crash-stats.mozilla.com/products/Firefox/versions/6.0.2/topchangers?duration=3"%2f%3E%3Cimg src=x onerror="alert(1)
PHP's in_array function was erroneously returning true. The string started with an integer that was in the array of integers, and in converting it during the compare something happens to make it evaluate true. We then return the non-converted value.
This will patch it by explicitly converting to an integer beforehand, and then returning the converted value (now just the integer, without the characters following it).
Lonnen: r+ and merged.
crash-stats.mozilla.com still vulnerable
minor syntax error (see crash-stats-dev), r? anyone:
(we should add a PHP linter to the jenkins steps :))
(In reply to Ervis Tusha from comment #3)
> crash-stats.mozilla.com still vulnerable
This will go live on crash-stats-dev.allizom.org automatically once landed (which resolving the bug signals) until we do a production release. Before a production release, QA will test on stage and mark "verified".
There will be a "push bug" for 2.3 (or whatever milestone the bug is set to) which will be used to track pushing it to production.
(In reply to Robert Helmer [:rhelmer] from comment #4)
> minor syntax error (see crash-stats-dev), r? anyone:
> (we should add a PHP linter to the jenkins steps :))
This is blocking QA, and I tested locally so merging myself (the XSS from comment 0 seems resolved btw).
Created attachment 563258 [details]
Verified FIXED on https://crash-stats-dev.allizom.org/products/Firefox/versions/6.0.2/topchangers?duration=3%22%2f%3E%3Cimg%20src=x%20onerror=%22alert%281%29
I think we could write a test for this; use urllib to verify that the URL returns a 200 OK, without an alert.