Closed Bug 689808 Opened 11 years ago Closed 11 years ago

Disable highlighter on aurora

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Version:
9 Branch
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox9+ fixed)

Status:
VERIFIED FIXED
Milestone:
Firefox 9
Tracking Flags:
Tracking Status
firefox9 + fixed

People

(Reporter: dcamp, Assigned: dcamp)

References

Details

(Keywords: verified-aurora, verified-beta, Whiteboard: [qa!])

Attachments

(2 files, 1 obsolete file)

Disable highlighter on aurora.
739 bytes, patch
rcampbell
: review+
jst
: approval-mozilla-aurora+
Details | Diff | Splinter Review
fix tests again
4.67 KB, patch
rcampbell
: review+
Details | Diff | Splinter Review 
Highlighter isn't ready to ship, disable it on aurora.
Attachment #562922 - Flags: review?(rcampbell)
Attachment #562922 - Flags: review?(rcampbell)
Attachment #562922 - Flags: review+
Attachment #562922 - Flags: approval-mozilla-aurora?
Attachment #562922 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attached patch fix tests (obsolete) — — Splinter Review
Attachment #567801 - Flags: review?
Attachment #567801 - Flags: review? → review?(rcampbell)
Comment on attachment 567801 [details] [diff] [review]
fix tests

also need to update these files:

./styleinspector/test/browser/browser_bug683672.js:  ok(StyleInspector.isEnabled, "style inspector preference is enabled");
./styleinspector/test/browser/browser_styleinspector.js:  ok(StyleInspector.isEnabled, "style inspector preference is enabled");
./styleinspector/test/browser/browser_styleinspector_bug_672744_search_filter.js:  ok(StyleInspector.isEnabled, "style inspector preference is enabled");
./styleinspector/test/browser/browser_styleinspector_bug_672746_default_styles.js:  ok(StyleInspector.isEnabled, "style inspector preference is enabled");
Attachment #567801 - Flags: review?(rcampbell) → review-
Attached patch fix tests again — — Splinter Review
Attachment #567801 - Attachment is obsolete: true
Attachment #567832 - Flags: review?
Comment on attachment 567832 [details] [diff] [review]
fix tests again

ok, I think that'll do it.
Attachment #567832 - Flags: review? → review+
https://hg.mozilla.org/releases/mozilla-aurora/rev/4efa58448392
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Depends on: 696167
Backed out in https://hg.mozilla.org/releases/mozilla-aurora/rev/1d546fa99f1b for test failures, filed bug 696167 with the test changes needed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/releases/mozilla-aurora/rev/8b0b938b03a6
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
status-firefox9: --- → fixed
Whiteboard: [qa+]
Verified that highlighter is disabled in Beta(9.0):
Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20100101 Firefox/9.0 (20111116091359)
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20100101 Firefox/9.0

Highlighter is available in Aurora (10.0) and Nightly (11.0):
Mozilla/5.0 (Windows NT 6.1; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (Windows NT 6.1; rv:11.0a1) Gecko/20111121 Firefox/11.0a1

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0a1) Gecko/20111121 Firefox/11.0a1

Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (Windows NT 5.1; rv:11.0a1) Gecko/20111121 Firefox/11.0a1

Mozilla/5.0 (X11; Linux x86_64; rv:10.0a2) Gecko/20111117 Firefox/10.0a2
Mozilla/5.0 (X11; Linux x86_64; rv:11.0a1) Gecko/20111118 Firefox/11.0a1
Status: RESOLVED → VERIFIED
Keywords: verified-aurora, verified-beta
Whiteboard: [qa+] → [qa!]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.