Last Comment Bug 689821 - Clean up browser/components/preferences/sync.js
: Clean up browser/components/preferences/sync.js
Status: RESOLVED FIXED
:
Product: Cloud Services
Classification: Client Software
Component: Firefox Sync: Backend (show other bugs)
: unspecified
: All All
: -- enhancement (vote)
: mozilla21
Assigned To: Sunny [:darkowlzz]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-27 18:14 PDT by Richard Newman [:rnewman]
Modified: 2013-06-07 23:30 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Gave some more love in the form of insertion of missing braces. (2.98 KB, patch)
2013-02-11 16:09 PST, Sunny [:darkowlzz]
rnewman: review+
Details | Diff | Splinter Review
Gave some more love in the form of insertion of missing braces. (3.01 KB, patch)
2013-02-12 05:00 PST, Sunny [:darkowlzz]
rnewman: review+
Details | Diff | Splinter Review

Description Richard Newman [:rnewman] 2011-09-27 18:14:27 PDT
This code could do with some love; even as simple as making it conform to *any* style guide.
Comment 1 Sunny [:darkowlzz] 2013-02-11 16:09:50 PST
Created attachment 712683 [details] [diff] [review]
Gave some more love in the form of insertion of missing braces.

Hope this love is enough :)
Comment 2 Richard Newman [:rnewman] 2013-02-11 19:03:42 PST
Comment on attachment 712683 [details] [diff] [review]
Gave some more love in the form of insertion of missing braces.

Review of attachment 712683 [details] [diff] [review]:
-----------------------------------------------------------------

N.B., you should have a # User line in your patch header.

r+ with nits. Thanks!

::: browser/components/preferences/sync.js
@@ +130,3 @@
>        gSyncUtils.changePassword();
> +    }
> +    else {

} else {

@@ +139,3 @@
>        gSyncUtils.resetPassword();
> +    }
> +    else {

} else {

@@ +144,5 @@
>    },
>  
>    /**
>     * Invoke the Sync setup wizard.
>     * 

Ooh! Trailing whitespace! :D

@@ +160,1 @@
>      else {

} else {

@@ +170,3 @@
>        win.focus();
> +    }
> +    else {

} else {

@@ +182,1 @@
>      

Trailing whitespace.

@@ +185,3 @@
>        win.focus();
> +    }
> +    else {

} else {
Comment 3 Sunny [:darkowlzz] 2013-02-12 05:00:56 PST
Created attachment 712869 [details] [diff] [review]
Gave some more love in the form of insertion of missing braces.

Added # User line.
Moved all the |else| to their proper positions.
Removed the white-spaces.
Comment 4 Richard Newman [:rnewman] 2013-02-12 10:01:44 PST
Comment on attachment 712869 [details] [diff] [review]
Gave some more love in the form of insertion of missing braces.

Review of attachment 712869 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thanks!
Comment 5 Richard Newman [:rnewman] 2013-02-12 15:17:07 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e65d7ccefd
Comment 6 Ryan VanderMeulen [:RyanVM] 2013-02-13 07:29:38 PST
https://hg.mozilla.org/mozilla-central/rev/c5e65d7ccefd

Note You need to log in before you can comment on or make changes to this bug.