Clean up browser/components/preferences/sync.js

RESOLVED FIXED in mozilla21

Status

Cloud Services
Firefox Sync: Backend
--
enhancement
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: rnewman, Assigned: darkowlzz)

Tracking

unspecified
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
This code could do with some love; even as simple as making it conform to *any* style guide.
(Reporter)

Updated

4 years ago
Whiteboard: [good first bug] → [good first bug][lang=js][mentor=rnewman]
(Assignee)

Comment 1

4 years ago
Created attachment 712683 [details] [diff] [review]
Gave some more love in the form of insertion of missing braces.

Hope this love is enough :)
Attachment #712683 - Flags: review?(rnewman)
(Reporter)

Comment 2

4 years ago
Comment on attachment 712683 [details] [diff] [review]
Gave some more love in the form of insertion of missing braces.

Review of attachment 712683 [details] [diff] [review]:
-----------------------------------------------------------------

N.B., you should have a # User line in your patch header.

r+ with nits. Thanks!

::: browser/components/preferences/sync.js
@@ +130,3 @@
>        gSyncUtils.changePassword();
> +    }
> +    else {

} else {

@@ +139,3 @@
>        gSyncUtils.resetPassword();
> +    }
> +    else {

} else {

@@ +144,5 @@
>    },
>  
>    /**
>     * Invoke the Sync setup wizard.
>     * 

Ooh! Trailing whitespace! :D

@@ +160,1 @@
>      else {

} else {

@@ +170,3 @@
>        win.focus();
> +    }
> +    else {

} else {

@@ +182,1 @@
>      

Trailing whitespace.

@@ +185,3 @@
>        win.focus();
> +    }
> +    else {

} else {
Attachment #712683 - Flags: review?(rnewman) → review+
(Reporter)

Updated

4 years ago
Assignee: nobody → indiasuny000
Status: NEW → ASSIGNED
(Assignee)

Comment 3

4 years ago
Created attachment 712869 [details] [diff] [review]
Gave some more love in the form of insertion of missing braces.

Added # User line.
Moved all the |else| to their proper positions.
Removed the white-spaces.
Attachment #712683 - Attachment is obsolete: true
Attachment #712869 - Flags: review?(rnewman)
(Reporter)

Comment 4

4 years ago
Comment on attachment 712869 [details] [diff] [review]
Gave some more love in the form of insertion of missing braces.

Review of attachment 712869 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thanks!
Attachment #712869 - Flags: review?(rnewman) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Reporter)

Comment 5

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e65d7ccefd
Keywords: checkin-needed
Whiteboard: [good first bug][lang=js][mentor=rnewman]
Target Milestone: --- → mozilla21
https://hg.mozilla.org/mozilla-central/rev/c5e65d7ccefd
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.