689821 - Clean up browser/components/preferences/sync.js

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Richard Newman [:rnewman]]

This code could do with some love; even as simple as making it conform to *any* style guide.

Comment 1

[Sunny [:darkowlzz]]

Attachment: Gave some more love in the form of insertion of missing braces.

Hope this love is enough :)

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 712683 [details] [diff] [review]
Gave some more love in the form of insertion of missing braces.

Review of attachment 712683 [details] [diff] [review]:
-----------------------------------------------------------------

N.B., you should have a # User line in your patch header.

r+ with nits. Thanks!

::: browser/components/preferences/sync.js
@@ +130,3 @@
>        gSyncUtils.changePassword();
> +    }
> +    else {

} else {

@@ +139,3 @@
>        gSyncUtils.resetPassword();
> +    }
> +    else {

} else {

@@ +144,5 @@
>    },
>  
>    /**
>     * Invoke the Sync setup wizard.
>     * 

Ooh! Trailing whitespace! :D

@@ +160,1 @@
>      else {

} else {

@@ +170,3 @@
>        win.focus();
> +    }
> +    else {

} else {

@@ +182,1 @@
>      

Trailing whitespace.

@@ +185,3 @@
>        win.focus();
> +    }
> +    else {

} else {

Comment 3

[Sunny [:darkowlzz]]

Attachment: Gave some more love in the form of insertion of missing braces.

Added # User line.
Moved all the |else| to their proper positions.
Removed the white-spaces.

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 712869 [details] [diff] [review]
Gave some more love in the form of insertion of missing braces.

Review of attachment 712869 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thanks!

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e65d7ccefd

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c5e65d7ccefd