Closed Bug 689862 Opened 13 years ago Closed 13 years ago

Only return the Classification name from Product.get, instead of all the classification info

Categories

(Bugzilla :: WebService, defect)

4.1.3
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: mkanat, Assigned: timello)

References

Details

Attachments

(1 file)

In Product.get, milestones, versions, and components are returned as hashes along with the get response. This is because they are unique items that can only be accessed in this way. On the other hand, returning classification as hash seems like a waste of response size to me, because when you get it for multiple products the information will be duplicated over and over. Instead, it would probably be best to simply return the classification name, and then later we can add a get_classification or something like that to Product.
Flags: blocking4.2+
Target Milestone: --- → Bugzilla 4.2
The size doesn't seem a valid argument to me. One classification is negligible compared to tens of versions, milestones and components. IMHO, it doesn't hurt to keep the data in Product.get.
That being said, I'm fine with this change.
Attached patch v1Splinter Review
Assignee: webservice → timello
Status: NEW → ASSIGNED
Attachment #565649 - Flags: review?(mkanat)
Comment on attachment 565649 [details] [diff] [review] v1 Looks good to me. r=LpSolit
Attachment #565649 - Flags: review?(mkanat) → review+
Flags: testcase?
Flags: approval4.2+
Flags: approval+
Blocks: 694755
Committing to: bzr+ssh://timello%40gmail.com@bzr.mozilla.org/bugzilla/4.2/ modified Bugzilla/WebService/Product.pm Committed revision 7947. Committing to: bzr+ssh://timello%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/WebService/Product.pm Committed revision 7985.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: