Closed Bug 689934 Opened 13 years ago Closed 13 years ago

Transition on infobar during webpage scrolling in highlighter

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 10

People

(Reporter: rcampbell, Assigned: paul)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 1 obsolete file)

patch v1
1.87 KB, patch
msucan
: review+
Details | Diff | Splinter Review 
With the infobar landed from bug 663833, when scrolling a webpage with a node "locked" in the highlighter, the infobar "chases" the node around. We should disable the transition during scrolling.
Summary: Transition on infobar during web pagescrolling in highlighter → Transition on infobar during webpagescrolling in highlighter
Summary: Transition on infobar during webpagescrolling in highlighter → Transition on infobar during webpage scrolling in highlighter
The transition is kinda nice when the infobar swaps positions relative to the highlighter box.
yes, but not so much during scrolling. Probably a low priority bug for now.
I don't quite see the problem... when I'm scrolling with a locked node, the transition seems to make it easier to not lose track of the infobar.
Attached patch patch v1 — — Splinter Review 
Assignee: nobody → paul
Status: NEW → ASSIGNED

        Attachment #566161 -
        Flags: review?

    
  

        Attachment #566161 -
        Flags: review? → review?(mihai.sucan)

    
    

    
  
Comment on attachment 566161 [details] [diff] [review]
patch v1

Review of attachment 566161 [details] [diff] [review]:
-----------------------------------------------------------------

This makes the infobar consistent with the highlight rectangle: both have no transitions once the node is locked. Thanks, r+!

        Attachment #566161 -
        Flags: review?(mihai.sucan) → review+

    
  
Whiteboard: [land-in-fx-team]

    
    

    
  

      
      
      
      

        Attached patch
          
          
        ignore this patch (obsolete)
        — 
          — Splinter Review
      

    


  

    
  

        Attachment #566184 -
        Attachment is obsolete: true

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/44411b4781c5
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/44411b4781c5
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: