The default bug view has changed. See this FAQ.

Docked HTML panel in the highlighter should remember its height

VERIFIED FIXED in Firefox 10

Status

()

Firefox
Developer Tools
P2
normal
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

unspecified
Firefox 10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [has-patch][fixed-in-fx-team][testday-20111125])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
The docked HTML panel should be able to remember its height when resized using the toolbar resizer. It should save its size to a preference named something like:

devtools.highlighter.html.height.

Updated

6 years ago
Blocks: 663830

Comment 1

6 years ago
We're doing developer tool prioritization, filter on 'brontozaur'
to ignore the spam.
Priority: -- → P2
(Assignee)

Comment 2

6 years ago
Created attachment 572239 [details] [diff] [review]
persist
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Whiteboard: [has-patch]
(Assignee)

Comment 3

5 years ago
Comment on attachment 572239 [details] [diff] [review]
persist

still needs a test, but a round of feedback while I write it couldn't hurt.
Attachment #572239 - Flags: feedback?(mihai.sucan)
(Assignee)

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All

Comment 4

5 years ago
Where do 112 and 64 come from?
(Assignee)

Comment 5

5 years ago
(In reply to Paul Rouget [:paul] from comment #4)
> Where do 112 and 64 come from?

no idea.
(Assignee)

Comment 6

5 years ago
Created attachment 572446 [details] [diff] [review]
Persist
Attachment #572239 - Attachment is obsolete: true
Attachment #572239 - Flags: feedback?(mihai.sucan)
Attachment #572446 - Flags: review?(mihai.sucan)
Comment on attachment 572446 [details] [diff] [review]
Persist

Review of attachment 572446 [details] [diff] [review]:
-----------------------------------------------------------------

I think you forgot to do qref. This patch is missing the test file. Make also fails.

The HTML panel height is hard-coded. Why not do window.innerHeight * 0.2 or something?
Attachment #572446 - Flags: review?(mihai.sucan)
(Assignee)

Comment 8

5 years ago
Comment on attachment 572446 [details] [diff] [review]
Persist

crap, forgot to hg add the file. standby...
(Assignee)

Comment 9

5 years ago
Created attachment 572483 [details] [diff] [review]
persist with test

here we go.
Attachment #572446 - Attachment is obsolete: true
Attachment #572483 - Flags: review?(mihai.sucan)
Comment on attachment 572483 [details] [diff] [review]
persist with test

Review of attachment 572483 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good, but I do have some nits (non-binding for the review):

- the default panel height is still hard-coded.
- there's trailing whitespace.
- test license should be the PD boilerplate.
- test doc.body.innerHTML is heavy - not needed for this kind of test.
- arguments.callee should no longer be used.
Attachment #572483 - Flags: review?(mihai.sucan) → review+
(Assignee)

Comment 11

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/7c054e3df274
Whiteboard: [has-patch] → [has-patch][fixed-in-fx-team]
Target Milestone: --- → Firefox 10
(Assignee)

Comment 12

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7c054e3df274
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 13

5 years ago
Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111123 Firefox/10.0a2
Verified fixed. http://screencast.com/t/YLYTA0lq
Status: RESOLVED → VERIFIED

Updated

5 years ago
Whiteboard: [has-patch][fixed-in-fx-team] → [has-patch][fixed-in-fx-team][testday-20111125]
You need to log in before you can comment on or make changes to this bug.