Closed Bug 689946 Opened 10 years ago Closed 10 years ago

Docked HTML panel in the highlighter should remember its height

Categories

(DevTools :: General, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 10

People

(Reporter: rcampbell, Assigned: rcampbell)

References

Details

(Whiteboard: [has-patch][fixed-in-fx-team][testday-20111125])

Attachments

(1 file, 2 obsolete files)

The docked HTML panel should be able to remember its height when resized using the toolbar resizer. It should save its size to a preference named something like:

devtools.highlighter.html.height.
Blocks: 663830
We're doing developer tool prioritization, filter on 'brontozaur'
to ignore the spam.
Priority: -- → P2
Attached patch persist (obsolete) — Splinter Review
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Whiteboard: [has-patch]
Comment on attachment 572239 [details] [diff] [review]
persist

still needs a test, but a round of feedback while I write it couldn't hurt.
Attachment #572239 - Flags: feedback?(mihai.sucan)
OS: Mac OS X → All
Hardware: x86 → All
Where do 112 and 64 come from?
(In reply to Paul Rouget [:paul] from comment #4)
> Where do 112 and 64 come from?

no idea.
Attached patch Persist (obsolete) — Splinter Review
Attachment #572239 - Attachment is obsolete: true
Attachment #572239 - Flags: feedback?(mihai.sucan)
Attachment #572446 - Flags: review?(mihai.sucan)
Comment on attachment 572446 [details] [diff] [review]
Persist

Review of attachment 572446 [details] [diff] [review]:
-----------------------------------------------------------------

I think you forgot to do qref. This patch is missing the test file. Make also fails.

The HTML panel height is hard-coded. Why not do window.innerHeight * 0.2 or something?
Attachment #572446 - Flags: review?(mihai.sucan)
Comment on attachment 572446 [details] [diff] [review]
Persist

crap, forgot to hg add the file. standby...
here we go.
Attachment #572446 - Attachment is obsolete: true
Attachment #572483 - Flags: review?(mihai.sucan)
Comment on attachment 572483 [details] [diff] [review]
persist with test

Review of attachment 572483 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good, but I do have some nits (non-binding for the review):

- the default panel height is still hard-coded.
- there's trailing whitespace.
- test license should be the PD boilerplate.
- test doc.body.innerHTML is heavy - not needed for this kind of test.
- arguments.callee should no longer be used.
Attachment #572483 - Flags: review?(mihai.sucan) → review+
https://hg.mozilla.org/integration/fx-team/rev/7c054e3df274
Whiteboard: [has-patch] → [has-patch][fixed-in-fx-team]
Target Milestone: --- → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/7c054e3df274
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111123 Firefox/10.0a2
Verified fixed. http://screencast.com/t/YLYTA0lq
Status: RESOLVED → VERIFIED
Whiteboard: [has-patch][fixed-in-fx-team] → [has-patch][fixed-in-fx-team][testday-20111125]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.