Closed
Bug 689946
Opened 13 years ago
Closed 13 years ago
Docked HTML panel in the highlighter should remember its height
Categories
(DevTools :: General, defect, P2)
DevTools
General
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 10
People
(Reporter: rcampbell, Assigned: rcampbell)
References
Details
(Whiteboard: [has-patch][fixed-in-fx-team][testday-20111125])
Attachments
(1 file, 2 obsolete files)
|
7.34 KB,
patch
|
msucan
:
review+
|
Details | Diff | Splinter Review |
The docked HTML panel should be able to remember its height when resized using the toolbar resizer. It should save its size to a preference named something like:
devtools.highlighter.html.height.
|
||
Comment 1•13 years ago
|
||
We're doing developer tool prioritization, filter on 'brontozaur'
to ignore the spam.
Priority: -- → P2
|
Assignee | |
Comment 2•13 years ago
|
||
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [has-patch]
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 572239 [details] [diff] [review]
persist
still needs a test, but a round of feedback while I write it couldn't hurt.
Attachment #572239 -
Flags: feedback?(mihai.sucan)
|
|
Assignee | |
Updated•13 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
|
||
Comment 4•13 years ago
|
||
Where do 112 and 64 come from?
|
|
Assignee | |
Comment 5•13 years ago
|
||
(In reply to Paul Rouget [:paul] from comment #4)
> Where do 112 and 64 come from?
no idea.
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #572239 -
Attachment is obsolete: true
Attachment #572239 -
Flags: feedback?(mihai.sucan)
Attachment #572446 -
Flags: review?(mihai.sucan)
|
||
Comment 7•13 years ago
|
||
Comment on attachment 572446 [details] [diff] [review]
Persist
Review of attachment 572446 [details] [diff] [review]:
-----------------------------------------------------------------
I think you forgot to do qref. This patch is missing the test file. Make also fails.
The HTML panel height is hard-coded. Why not do window.innerHeight * 0.2 or something?
Attachment #572446 -
Flags: review?(mihai.sucan)
|
|
Assignee | |
Comment 8•13 years ago
|
||
Comment on attachment 572446 [details] [diff] [review]
Persist
crap, forgot to hg add the file. standby...
|
|
Assignee | |
Comment 9•13 years ago
|
||
here we go.
Attachment #572446 -
Attachment is obsolete: true
Attachment #572483 -
Flags: review?(mihai.sucan)
|
|
||
Comment 10•13 years ago
|
||
Comment on attachment 572483 [details] [diff] [review]
persist with test
Review of attachment 572483 [details] [diff] [review]:
-----------------------------------------------------------------
Patch looks good, but I do have some nits (non-binding for the review):
- the default panel height is still hard-coded.
- there's trailing whitespace.
- test license should be the PD boilerplate.
- test doc.body.innerHTML is heavy - not needed for this kind of test.
- arguments.callee should no longer be used.
Attachment #572483 -
Flags: review?(mihai.sucan) → review+
|
|
Assignee | |
Comment 11•13 years ago
|
||
Whiteboard: [has-patch] → [has-patch][fixed-in-fx-team]
Target Milestone: --- → Firefox 10
|
|
Assignee | |
Comment 12•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 13•13 years ago
|
||
Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111123 Firefox/10.0a2
Verified fixed. http://screencast.com/t/YLYTA0lq
Status: RESOLVED → VERIFIED
Whiteboard: [has-patch][fixed-in-fx-team] → [has-patch][fixed-in-fx-team][testday-20111125]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•