Closed Bug 689966 Opened 11 years ago Closed 11 years ago

Custom Page has a double entry for Start Page option

Categories

(Firefox for Android Graveyard :: General, defect)

Firefox 9
ARM
Android
defect
Not set
normal

Tracking

(firefox9 fixed, fennec9+)

VERIFIED FIXED
Firefox 9
Tracking Status
firefox9 --- fixed
fennec 9+ ---

People

(Reporter: xti, Assigned: mbrubeck)

References

Details

(Keywords: regression, Whiteboard: [pushed])

Attachments

(2 files)

Attached image screenshot
Build ID: Mozilla/5.0 (Android;Linux armv7l;rv:9.0a2)Gecko/20110928
Firefox/9.0a2 Fennec/9.0a2
Device: Samsung Galaxy S
OS: Android 2.2

Build ID: Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20110928
Firefox/10.0a1 Fennec/10.0a1
Device: Samsung Galaxy S
OS: Android 2.2

Steps to reproduce:
1. Open Fennec App
2. Browse to www.google.com
3. Go to Preferences > Start Page 
4. Select Custom Page
5. Open a new tab and go to www.mozilla.com
6. Repeat step 3

Expected result:
After step 4, no Start Page entry is duplicated.

Actual result:
Custom Page option is listed twice as you can see on the attached screenshot.
Assignee: nobody → wjohnston
Attached patch patchSplinter Review
Bug 658278 removed the prefs-languages element, but the preferences initialization code was still looking for it, so it ended up initializing stuff more than once.
Assignee: wjohnston → mbrubeck
Status: NEW → ASSIGNED
Attachment #563166 - Flags: review?(wjohnston)
Nominating for tracking-fennec.  This regression affects Firefox 9 and may cause other subtler bugs.  We should request approval to land this in Aurora when it has been reviewed and pushed.
Blocks: 658278
tracking-fennec: --- → ?
Keywords: regression
Version: Trunk → Firefox 9
tracking-fennec: ? → 9+
Comment on attachment 563166 [details] [diff] [review]
patch

Thanks matt!
Attachment #563166 - Flags: review?(wjohnston) → review+
Comment on attachment 563166 [details] [diff] [review]
patch

Requesting approval for Aurora 9.  This fixes a regression introduced in Firefox 9.  The symptoms are not serious, but they are user-visible, and the nature of the regression makes me think there may be more subtle symptoms that we haven't found yet.  The fix is mobile-only, very localized, and safe.  It removes a attempt to reference a non-existent XUL element.
Attachment #563166 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/7cc26b83a57c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Attachment #563166 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Pushed to Aurora for Firefox 9:
https://hg.mozilla.org/releases/mozilla-aurora/rev/b9a6752584aa
Target Milestone: Firefox 10 → Firefox 9
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a2)Gecko/20110930
Firefox/9.0a2 Fennec/9.0a2
Device: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.