689966 - Custom Page has a double entry for Start Page option

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

Attachment: screenshot

Build ID: Mozilla/5.0 (Android;Linux armv7l;rv:9.0a2)Gecko/20110928
Firefox/9.0a2 Fennec/9.0a2
Device: Samsung Galaxy S
OS: Android 2.2

Build ID: Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20110928
Firefox/10.0a1 Fennec/10.0a1
Device: Samsung Galaxy S
OS: Android 2.2

Steps to reproduce:
1. Open Fennec App
2. Browse to www.google.com
3. Go to Preferences > Start Page 
4. Select Custom Page
5. Open a new tab and go to www.mozilla.com
6. Repeat step 3

Expected result:
After step 4, no Start Page entry is duplicated.

Actual result:
Custom Page option is listed twice as you can see on the attached screenshot.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Bug 658278 removed the prefs-languages element, but the preferences initialization code was still looking for it, so it ended up initializing stuff more than once.

Comment 2

[Matt Brubeck (:mbrubeck)]

Nominating for tracking-fennec.  This regression affects Firefox 9 and may cause other subtler bugs.  We should request approval to land this in Aurora when it has been reviewed and pushed.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 563166 [details] [diff] [review]
patch

Thanks matt!

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7cc26b83a57c

Comment 5

[Matt Brubeck (:mbrubeck)]

Comment on attachment 563166 [details] [diff] [review]
patch

Requesting approval for Aurora 9.  This fixes a regression introduced in Firefox 9.  The symptoms are not serious, but they are user-visible, and the nature of the regression makes me think there may be more subtle symptoms that we haven't found yet.  The fix is mobile-only, very localized, and safe.  It removes a attempt to reference a non-existent XUL element.

Comment 6

[Michael Wu [:mwu]]

https://hg.mozilla.org/mozilla-central/rev/7cc26b83a57c

Comment 7

[Matt Brubeck (:mbrubeck)]

Pushed to Aurora for Firefox 9:
https://hg.mozilla.org/releases/mozilla-aurora/rev/b9a6752584aa

Comment 8

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a2)Gecko/20110930
Firefox/9.0a2 Fennec/9.0a2
Device: Samsung Galaxy S
OS: Android 2.2