690068 - highlighter and infobar should not be visible if node is not highlightable

Status: RESOLVED FIXED

(DevTools :: General, defect)

Comment 1

[Dave Camp (:dcamp)]

Also, it feels like the box animates while it shrinks down to that pixel size, aren't the animations disabled while locked?

Comment 2

[Paul Rouget [:paul]]

I found another situation where the highlighter and/or the infobar are still visible when they should not (selecting a non-highlightable node after a highlightable node).

Comment 3

[Paul Rouget [:paul]]

I think the infobar should be move to the top/left corner, bot be hidden.

Comment 4

[Paul Rouget [:paul]]

Attachment: patch v1

- hide the highlighter borders if node not highlitable
- move the infobar to the top-left corner if node not highlitable

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 566151 [details] [diff] [review]
patch v1

     // node is not set or node is not highlightable, bail
-    if (!this.node || !this.isNodeHighlightable(this.node)) {
-      return;
-    }
+    if (this.node && this.isNodeHighlightable(this.node)) {

I think I'd prefer to bail out early rather than nest the remainder of this method in an if { } block.

r+ with that reverted.

Comment 6

[Paul Rouget [:paul]]

Well, actually, we don't want to bail out here. We want to execute:

>    this.highlightRectangle(rect);
>    this.moveInfobar();

(after the if block).

I think here I should only remove the comment.

Comment 7

[Rob Campbell [:rc] (:robcee)]

(In reply to Paul Rouget [:paul] from comment #6)
> Well, actually, we don't want to bail out here. We want to execute:
> 
> >    this.highlightRectangle(rect);
> >    this.moveInfobar();
> 
> (after the if block).
> 
> I think here I should only remove the comment.

OK, fair enough.

One thing I would like to see fixed though is the while(true) block. Can we replace that with something like:

while (!(frameWin.parent === frameWin || !frameWin.frameElement)) {

?

or do { ... } while() ?

Comment 8

[Paul Rouget [:paul]]

(In reply to Rob Campbell [:rc] (robcee) from comment #7)
> (In reply to Paul Rouget [:paul] from comment #6)
> > Well, actually, we don't want to bail out here. We want to execute:
> > 
> > >    this.highlightRectangle(rect);
> > >    this.moveInfobar();
> > 
> > (after the if block).
> > 
> > I think here I should only remove the comment.
> 
> OK, fair enough.
> 
> One thing I would like to see fixed though is the while(true) block. Can we
> replace that with something like:
> 
> while (!(frameWin.parent === frameWin || !frameWin.frameElement)) {
> 
> ?
> 
> or do { ... } while() ?

I don't see how I could do that.

Comment 9

[Rob Campbell [:rc] (:robcee)]

ok, after another look, it looks like it'll be a pain to move that around, so don't worry about it.

Comment 10

[Paul Rouget [:paul]]

Attachment: patch v1.1

removed the comfusing comment

Comment 11

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/f9644e6e81d5

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f9644e6e81d5