690113 - Forgot password missing user's email in To: field

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Austin King [:ozten]]

Steps to Reproduce

1) Click Login
2) Click forgot password link
3) Enter an email address that exists in the system

Expected:
User is emailed

Actual:
An email with an empty To field is generated
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Password reset on 127.0.0.1:8001
From: webmaster@localhost
To: 
Date: Wed, 28 Sep 2011 21:53:51 -0000
Message-ID: <[e-mail].>
...

Resulting in an Error:

Traceback (most recent call last):

  File "/data/www/mozillians.allizom.org/mozillians/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/mozillians.allizom.org/mozillians/apps/users/views.py", line 111, in password_reset
    reverse('password_reset_check_mail'))

  File "/data/www/mozillians.allizom.org/mozillians/vendor/src/django/django/utils/decorators.py", line 91, in _wrapped_view
    response = view_func(request, *args, **kwargs)

  File "/data/www/mozillians.allizom.org/mozillians/vendor/src/django/django/contrib/auth/views.py", line 160, in password_reset
    form.save(**opts)

  File "/data/www/mozillians.allizom.org/mozillians/apps/users/forms.py", line 185, in save
    send_mail(subject, email, from_email, [user.email])

  File "/data/www/mozillians.allizom.org/mozillians/vendor/src/django/django/core/mail/__init__.py", line 61, in send_mail
    connection=connection).send()

  File "/data/www/mozillians.allizom.org/mozillians/vendor/src/django/django/core/mail/message.py", line 248, in send
    return self.get_connection(fail_silently).send_messages([self])

  File "/data/www/mozillians.allizom.org/mozillians/vendor/src/django/django/core/mail/backends/smtp.py", line 86, in send_messages
    sent = self._send(message)

  File "/data/www/mozillians.allizom.org/mozillians/vendor/src/django/django/core/mail/backends/smtp.py", line 104, in _send
    email_message.message().as_string())

  File "/usr/lib/python2.6/smtplib.py", line 709, in sendmail
    raise SMTPRecipientsRefused(senderrs)

SMTPRecipientsRefused: {'': (501, '5.1.3 Bad recipient address syntax')}

Comment 1

[Austin King [:ozten]]

Oddly: I can't repro on https://mozillians-dev.allizom.org, but stage and my local copy, do reproduce.

Comment 2

[Austin King [:ozten]]

The issue is that django contrib auth uses user.email as the input into forgot your password.

(I'm not sure why, but) We no longer populate user_auth's email column.

Digging...

Comment 3

[[github robot]]

Commit pushed to https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/83ecb166981c5e0260a19c677ea8db23af0bc271
Our current registration/login flow isn't populating email address. Adding pre_save signal, fixes Bug#690113

Comment 4

[Austin King [:ozten]]

Proposed fix in https://github.com/mozilla/mozillians/pull/17

Comment 5

[[github robot]]

Commit pushed to https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/3fb695690c085423f3a22cb709ec7e7f3c911c4e
Adding pre_save signal, fixes Bug#690113 r=davedash

Our current registration/login flow isn't populating email address.

Comment 6

[Tobias (:Tobbi) Markus]

Verified I get a Password reset email.