The default bug view has changed. See this FAQ.

fix mac build with clang

RESOLVED FIXED in Firefox 9

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

Trunk
mozilla10
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox9 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Created attachment 563303 [details] [diff] [review]
fix the clang build

+++ This bug was initially created as a clone of Bug #689397 +++

This is a small part of 689397 that can be committed earlier and fixes the clang build.
Attachment #563303 - Flags: review?(ehsan)
Attachment #563303 - Attachment is patch: true
Try at
https://tbpl.mozilla.org/?tree=Try&rev=84599c41c8c4
Comment on attachment 563303 [details] [diff] [review]
fix the clang build

r=me.
Attachment #563303 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac24c47e2885
Assignee: nobody → respindola
Target Milestone: --- → mozilla10
Comment on attachment 563303 [details] [diff] [review]
fix the clang build

This is a very low risk patch, which effectively doesn't change any semantics, but enables Aurora to be built using clang.
Attachment #563303 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/f96e4ff817a7

I accidentally pushed this patch to mozilla-central while it was living on inbound.  On the next merge, it will be merged.  Sorry for the mess!
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Attachment #563303 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Merged from inbound: https://hg.mozilla.org/mozilla-central/rev/ac24c47e2885
http://hg.mozilla.org/releases/mozilla-aurora/rev/485f3c637b11
status-firefox9: --- → fixed
Is there something QA can do to verify this fix?
Whiteboard: [qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #8)
> Is there something QA can do to verify this fix?

I don't think so, it was just a build fix.
Whiteboard: [qa?] → [qa-]
You need to log in before you can comment on or make changes to this bug.