Closed
Bug 690235
Opened 13 years ago
Closed 13 years ago
fix mac build with clang
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
Tracking | Status | |
---|---|---|
firefox9 | --- | fixed |
People
(Reporter: espindola, Assigned: espindola)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
732 bytes,
patch
|
ehsan.akhgari
:
review+
jst
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #689397 +++
This is a small part of 689397 that can be committed earlier and fixes the clang build.
Attachment #563303 -
Flags: review?(ehsan)
Assignee | ||
Updated•13 years ago
|
Attachment #563303 -
Attachment is patch: true
Assignee | ||
Comment 1•13 years ago
|
||
Comment 2•13 years ago
|
||
Comment on attachment 563303 [details] [diff] [review]
fix the clang build
r=me.
Attachment #563303 -
Flags: review?(ehsan) → review+
Comment 3•13 years ago
|
||
Assignee: nobody → respindola
Target Milestone: --- → mozilla10
Comment 4•13 years ago
|
||
Comment on attachment 563303 [details] [diff] [review]
fix the clang build
This is a very low risk patch, which effectively doesn't change any semantics, but enables Aurora to be built using clang.
Attachment #563303 -
Flags: approval-mozilla-aurora?
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f96e4ff817a7
I accidentally pushed this patch to mozilla-central while it was living on inbound. On the next merge, it will be merged. Sorry for the mess!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Attachment #563303 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 6•13 years ago
|
||
Merged from inbound: https://hg.mozilla.org/mozilla-central/rev/ac24c47e2885
Comment 7•13 years ago
|
||
status-firefox9:
--- → fixed
Assignee | ||
Comment 9•13 years ago
|
||
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #8)
> Is there something QA can do to verify this fix?
I don't think so, it was just a build fix.
You need to log in
before you can comment on or make changes to this bug.
Description
•