690365 - Disable the upload_snippets step to aus2.beta directory if useBetaChannel is set to 1

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

I think we'd lose the beta snippets for 3.6.x if we did that. Was there a problem with a Beta or Release automation run ?

Comment 2

[Justin Wood (:Callek)]

(In reply to Nick Thomas [:nthomas] from comment #1)
> I think we'd lose the beta snippets for 3.6.x if we did that. Was there a
> problem with a Beta or Release automation run ?

Yes it fails in new-style mozilla-release builds:
https://wiki.mozilla.org/Releases/Firefox_7.0/BuildNotes#Updates

Basically we have useBetaChannel=1 properly in the release config (see e-mail to release@ for more info on that setting). But our release patcher configs do not have a beta channel created. This results in buildbotcustom expecting to have an aus2.beta dir and expecting to be able to upload it.

Two separate options I can think of here:
1) Make buildbotcustom do a setProperty of a test, if aus2.beta dir exists, and skip the attempt at uploading it if missing
** Downside: No good check to tell us when the dir doesn't exist if it was expected.
2) Expand useBetaChannel to be a tristate flag not a 0/1 flag, with either -1 or 2 as the third state, to indicate that we want the release-channel at all, but don't need beta channel.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Hit this on the 8.0 release, updates fail on trying to upload to aus2.beta and we have to trigger update_verify manually.

Comment 4

[Rail Aliiev [:rail]]

Attachment: add useBetaChannelForRelease variable

In ideal world I would prefer to patch patcher2.pl to accept channels and test channels other than {beta,release}{,test} but very soon AUS2 will be obsoleted by Balrog, so here is a dirty-ish solution.

It introduces useBetaChannelForRelease releaseConfig variable and you can prevent any operation with aus2.beta (only for buildbotcustom).

Configs incoming.

Comment 5

[Rail Aliiev [:rail]]

Attachment: configs

We still need aus2.beta for 1.9.2

Comment 6

[Rail Aliiev [:rail]]

I tested the patches in staging and they worked. It would be great to land them before 9.0.

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 580940 [details] [diff] [review]
add useBetaChannelForRelease variable

http://hg.mozilla.org/build/buildbotcustom/rev/0dfd8d471928

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 580941 [details] [diff] [review]
configs

http://hg.mozilla.org/build/buildbot-configs/rev/ac518b2b4392

Comment 9

[Rail Aliiev [:rail]]

Yay!