690433 - Specifying invalid numbers to /invited/ results in a 500 error message

Status: VERIFIED WORKSFORME

(Participation Infrastructure :: Phonebook, defect)

Description

[Tobias (:Tobbi) Markus]

https://mozillians.allizom.org/en-US/invited/110000


Traceback (most recent call last):

  File "/data/www/mozillians.allizom.org/mozillians/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/mozillians.allizom.org/mozillians/vendor/src/django/django/contrib/auth/decorators.py", line 19, in _wrapped_view
    return view_func(request, *args, **kwargs)

  File "/data/www/mozillians.allizom.org/mozillians/apps/phonebook/views.py", line 259, in invited
    invite = Invite.objects.get(pk=id)

  File "/data/www/mozillians.allizom.org/mozillians/vendor/src/django/django/db/models/manager.py", line 132, in get
    return self.get_query_set().get(*args, **kwargs)

  File "/data/www/mozillians.allizom.org/mozillians/vendor/src/django/django/db/models/query.py", line 349, in get
    % self.model._meta.object_name)

DoesNotExist: Invite matching query does not exist.

Comment 1

[Aakash Desai [:aakashd]]

Invalid numbers should show an error message. I believe the app is working as expected.

Comment 2

[Matt Brandt [:mbrandt]]

Bumping to reopened: 
The landscape of the invite urls has changed (ex: https://mozillians.allizom.org/en-US/register?code=HHys6).

That said I suspect the app should catch that exception and not throw a 500 error.

[11:36:33.573] GET https://mozillians.allizom.org/en-US/invited/110000 [HTTP/1.1 500 INTERNAL SERVER ERROR 313ms]

Comment 3

[Ben (:bensternthal)]

Tried re-producing and could-not. Likely fixed but this bug was never updated.

Comment 4

[Matt Brandt [:mbrandt]]

QA verified WFM .. thanks Ben