ShadowCanvasLayer::RenderLayer doesn't ApplyFilter for each tile

RESOLVED FIXED in mozilla10

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ajuma, Assigned: ajuma)

Tracking

Trunk
mozilla10
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
It should really ApplyFilter after each texture tile is bound.
(Assignee)

Comment 1

6 years ago
Created attachment 563564 [details] [diff] [review]
Make ShadowCanvasLayer::RenderLayer apply filter for each tile
Attachment #563564 - Flags: review?(bgirard)
Comment on attachment 563564 [details] [diff] [review]
Make ShadowCanvasLayer::RenderLayer apply filter for each tile

Passing the review along. We worked together on that patch.
Attachment #563564 - Flags: review?(bgirard) → review?(jmuizelaar)
Comment on attachment 563564 [details] [diff] [review]
Make ShadowCanvasLayer::RenderLayer apply filter for each tile

we should see if we can associate the filter more closely with the texture image, because it is texture state and not glcontext state.
Attachment #563564 - Flags: review?(jmuizelaar) → review-
(Assignee)

Comment 4

6 years ago
Created attachment 564659 [details] [diff] [review]
Associate filters with texture images.

In addition to associating filters with texture images, this also moves ApplyFilter from LayerOGL to GLContext and renames it to ApplyFilterToBoundTexture.
Attachment #563564 - Attachment is obsolete: true
Attachment #564659 - Flags: review?(jmuizelaar)
Comment on attachment 564659 [details] [diff] [review]
Associate filters with texture images.

Review of attachment 564659 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is clearer than before. I'd be interested to hear what others think.
Attachment #564659 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cdcfb799ff50
Target Milestone: --- → mozilla10

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/cdcfb799ff50
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.