690566 - ShadowCanvasLayer::RenderLayer doesn't ApplyFilter for each tile

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ali Juma [:ajuma]]

It should really ApplyFilter after each texture tile is bound.

Comment 1

[Ali Juma [:ajuma]]

Attachment: Make ShadowCanvasLayer::RenderLayer apply filter for each tile

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 563564 [details] [diff] [review]
Make ShadowCanvasLayer::RenderLayer apply filter for each tile

Passing the review along. We worked together on that patch.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 563564 [details] [diff] [review]
Make ShadowCanvasLayer::RenderLayer apply filter for each tile

we should see if we can associate the filter more closely with the texture image, because it is texture state and not glcontext state.

Comment 4

[Ali Juma [:ajuma]]

Attachment: Associate filters with texture images.

In addition to associating filters with texture images, this also moves ApplyFilter from LayerOGL to GLContext and renames it to ApplyFilterToBoundTexture.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 564659 [details] [diff] [review]
Associate filters with texture images.

Review of attachment 564659 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is clearer than before. I'd be interested to hear what others think.

Comment 6

[Ali Juma [:ajuma]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cdcfb799ff50

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cdcfb799ff50