Closed Bug 690648 Opened 8 years ago Closed 8 years ago

Clarify popup-only move/resize window preference label

Categories

(Firefox :: Preferences, defect)

7 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 10

People

(Reporter: emk, Assigned: fryn)

References

Details

Attachments

(1 file, 2 obsolete files)

The label "Move or resize existing windows" is not accurate because we do no longer allow moving or resizing main window regardless of the option state.
It should be changed to something like "Move or resize popup windows".
Summary: The label for the JavaScript options should be changed → Clarify popup-only move/resize window preference label
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → fryn
Status: NEW → ASSIGNED
Attachment #563648 - Flags: ui-review?(faaborg)
Attachment #563648 - Flags: review?(dao)
Comment on attachment 563648 [details] [diff] [review]
patch

Need to change the entity name so that localizers pick up the change.
Attachment #563648 - Flags: review?(dao) → review-
Attachment #563648 - Flags: ui-review?(faaborg) → ui-review+
Attached patch patch v2 [ui-r=faaborg] (obsolete) — Splinter Review
Rev'd entity names.
Attachment #563648 - Attachment is obsolete: true
Attachment #566919 - Flags: review?(dao)
Comment on attachment 566919 [details] [diff] [review]
patch v2 [ui-r=faaborg]

moveResizePopupWindows? moveResizeWindows2 is kind of silly.

The checkbox id could be updated as well, although this is less important since it's unused.
Attachment #566919 - Flags: review?(dao) → review-
(In reply to Dão Gottwald [:dao] from comment #4)
> moveResizePopupWindows? moveResizeWindows2 is kind of silly.

Good idea.
Attachment #567188 - Flags: review?(dao)
Attachment #566919 - Attachment is obsolete: true
Attachment #567188 - Attachment description: patch v3 → patch v3 [ui-r=faaborg]
Attachment #567188 - Flags: review?(dao) → review+
https://hg.mozilla.org/integration/fx-team/rev/7feb84367f15
Version: unspecified → 10 Branch
Target Milestone: --- → Firefox 10
Version: 10 Branch → 7 Branch
https://hg.mozilla.org/mozilla-central/rev/7feb84367f15
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.