Stop creating QWidget in DragService ctor

RESOLVED FIXED in mozilla10

Status

Core Graveyard
Widget: Qt
RESOLVED FIXED
6 years ago
10 months ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla10
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
DragService creating toplevel QWidget in ctor which is bad and prevent gecko init in non-main thread
(Assignee)

Comment 1

6 years ago
Created attachment 563657 [details] [diff] [review]
Stop creating QWidget in dragservice ctor
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #563657 - Flags: review?(doug.turner)

Updated

6 years ago
Attachment #563657 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 2

6 years ago
Created attachment 563662 [details] [diff] [review]
Don't use main-thread only functionality in non-main thread

Oh, found that we also should not install XEvent handler in non-main thread.
Also added check new QWidget and prevent that calling in non-main thread.
Attachment #563662 - Flags: review?(doug.turner)
(Assignee)

Comment 3

6 years ago
Created attachment 563675 [details] [diff] [review]
Don't use main-thread only functionality in non-main thread
Attachment #563662 - Attachment is obsolete: true
Attachment #563662 - Flags: review?(doug.turner)
Attachment #563675 - Flags: review?(doug.turner)

Updated

6 years ago
Attachment #563675 - Flags: review?(doug.turner) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 4

6 years ago
In my queue, which is heading to try first then inbound :-)
https://tbpl.mozilla.org/?tree=Try&rev=a8fbb2a76633
Keywords: checkin-needed

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e64926f9e278
https://hg.mozilla.org/integration/mozilla-inbound/rev/776a816fe364
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/e64926f9e278
https://hg.mozilla.org/mozilla-central/rev/776a816fe364
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.