Last Comment Bug 690656 - Stop creating QWidget in DragService ctor
: Stop creating QWidget in DragService ctor
Status: RESOLVED FIXED
:
Product: Core Graveyard
Classification: Graveyard
Component: Widget: Qt (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla10
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-29 22:19 PDT by Oleg Romashin (:romaxa)
Modified: 2016-07-11 21:54 PDT (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Stop creating QWidget in dragservice ctor (1.52 KB, patch)
2011-09-29 22:22 PDT, Oleg Romashin (:romaxa)
dougt: review+
Details | Diff | Splinter Review
Don't use main-thread only functionality in non-main thread (5.82 KB, patch)
2011-09-29 22:54 PDT, Oleg Romashin (:romaxa)
no flags Details | Diff | Splinter Review
Don't use main-thread only functionality in non-main thread (4.44 KB, patch)
2011-09-30 00:09 PDT, Oleg Romashin (:romaxa)
dougt: review+
Details | Diff | Splinter Review

Description Oleg Romashin (:romaxa) 2011-09-29 22:19:51 PDT
DragService creating toplevel QWidget in ctor which is bad and prevent gecko init in non-main thread
Comment 1 Oleg Romashin (:romaxa) 2011-09-29 22:22:45 PDT
Created attachment 563657 [details] [diff] [review]
Stop creating QWidget in dragservice ctor
Comment 2 Oleg Romashin (:romaxa) 2011-09-29 22:54:02 PDT
Created attachment 563662 [details] [diff] [review]
Don't use main-thread only functionality in non-main thread

Oh, found that we also should not install XEvent handler in non-main thread.
Also added check new QWidget and prevent that calling in non-main thread.
Comment 3 Oleg Romashin (:romaxa) 2011-09-30 00:09:13 PDT
Created attachment 563675 [details] [diff] [review]
Don't use main-thread only functionality in non-main thread
Comment 4 Ed Morley [:emorley] 2011-10-07 03:30:42 PDT
In my queue, which is heading to try first then inbound :-)
https://tbpl.mozilla.org/?tree=Try&rev=a8fbb2a76633

Note You need to log in before you can comment on or make changes to this bug.