Last Comment Bug 690669 - Remove PR_TRUE/PR_FALSE from widget/src/windows
: Remove PR_TRUE/PR_FALSE from widget/src/windows
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Widget: Win32 (show other bugs)
: Trunk
: All Windows 7
: -- normal (vote)
: mozilla10
Assigned To: Masayuki Nakano [:masayuki] (Mozilla Japan)
:
Mentors:
Depends on:
Blocks: 675553
  Show dependency treegraph
 
Reported: 2011-09-29 23:23 PDT by Masayuki Nakano [:masayuki] (Mozilla Japan)
Modified: 2011-10-03 08:00 PDT (History)
4 users (show)
masayuki: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (354.66 KB, patch)
2011-09-29 23:23 PDT, Masayuki Nakano [:masayuki] (Mozilla Japan)
jmathies: review+
Details | Diff | Splinter Review

Description Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-09-29 23:23:56 PDT
Created attachment 563665 [details] [diff] [review]
Patch

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=b7c0e8d396d7
Comment 1 Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-09-29 23:27:02 PDT
The patch is automatically generated by my editor.
I used ([ ,({])PR_TRUE([ ,);}\n]) for matching PR_TRUE. And same for PR_FALSE.
Comment 2 Makoto Kato [:m_kato] 2011-09-30 00:08:49 PDT
Nakano-san, Could you fix nsWindow::OnPaint() (nsWindowGfx.cpp) too?  This function returns bool type, but it offen uses NS_ERROR_FAILURE for error.
Comment 3 Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-09-30 00:22:50 PDT
I think that it should have another bug#.
Comment 4 Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-10-01 19:21:22 PDT
Nobody landed patches in m-c directly, therefore, I landed the patch in m-i.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c481048e522
Comment 5 Marco Bonardo [::mak] 2011-10-03 08:00:07 PDT
https://hg.mozilla.org/mozilla-central/rev/0c481048e522

Please stop doing PR_TRUE/PR_FALSE convertions till the PRBool regression is figured out (see the topic in mozilla.dev.planning)

Note You need to log in before you can comment on or make changes to this bug.