Closed
Bug 690669
Opened 13 years ago
Closed 13 years ago
Remove PR_TRUE/PR_FALSE from widget/src/windows
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
354.66 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•13 years ago
|
||
The patch is automatically generated by my editor.
I used ([ ,({])PR_TRUE([ ,);}\n]) for matching PR_TRUE. And same for PR_FALSE.
|
||
Comment 2•13 years ago
|
||
Nakano-san, Could you fix nsWindow::OnPaint() (nsWindowGfx.cpp) too? This function returns bool type, but it offen uses NS_ERROR_FAILURE for error.
|
|
Assignee | |
Comment 3•13 years ago
|
||
I think that it should have another bug#.
|
|
Assignee | |
Updated•13 years ago
|
Attachment #563665 -
Flags: review?(jmathies)
|
||
Updated•13 years ago
|
Attachment #563665 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Nobody landed patches in m-c directly, therefore, I landed the patch in m-i. https://hg.mozilla.org/integration/mozilla-inbound/rev/0c481048e522
Flags: in-testsuite-
Whiteboard: [inbound]
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0c481048e522 Please stop doing PR_TRUE/PR_FALSE convertions till the PRBool regression is figured out (see the topic in mozilla.dev.planning)
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•