69069 - update mozilla user agent string to 0.8.1

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P2)

Description

[Jon Granrose]

We need to update the mozilla user agent string from 0.8 to 0.9 now that 0.8 has
shipped.  This is the same string that appears on the help about page as
(Windows; U; Win98; en-US; 0.8).

Assigning to Kyle as a learning experience.  Hint: use lxr to search the mozilla
tree, or search bugzilla for how we changed moz 0.8.  and feel free to ask leaf,
jj and myself for any assistance figuring it out.  attach any patches to this
bug for review by the team.

cc'ing the whole team.

Comment 1

[Daniel (Leaf) Nunes]

are we sure we want 0.9 and not 0.8+ until the 0.9 release is made? cc'ing asa 
as he should have some say in this.

Comment 2

[Asa Dotzler [:asa]]

I like the 0.8+.  I do not like the 0.9 which I think should not happen until
the 0.9 branch at the earliest.  I'm ready to be overruled on this but folks
look at the user agent to report bugs and I'd rather see 0.8+ (or something
similar) in the bug report and have the actual "0.8" or "0.9" oactually mean
that it was a release (or at least a branch) build.  

Comment 3

[Jon Granrose]

but don't most people use build ids when reporting bugs?

I'm just trying to reduce the amount of work involved by only having to update
the user agent string once per release.  Otherwise you end up with a user agent
string on the trunk that's several revs old since no one bothers to update it
(m18, anyone?).  If we don't want to preemptively update the user agent string,
then perhaps we should do away with it and make it "trunk" or "tip" and only put
actual numbers on the branch when we're going to release a specific version,
like we did for the directory names on ftp.mozilla.org (-Mtrunk).

Comment 4

[timeless]

i'd prefer pre0.9

buildid's are fine for bugzilla, but the rest of the world doesn't want to 
think about them.

Comment 5

[Jon Granrose]

hmm, my earlier comments didn't take.

It's a mozilla product so I'll leave it to mozilla to say what they want in the
mozilla user agent.

We always update the Netscape user agent ahead of time because there are always
many many more important things to worry about come release time than if you
remembered to update the user agent string on the branch (or trunk) or not.  If
you think you can keep the user agent up to date and change it twice every 5
weeks, you're welcome to try.  It doesn't sound like much, but it's amazing how
the little things fall through the cracks when you're worried about driving the
bug list to zero.

It sounds like 0.8+ has two votes, so let's change it to that, and I'll leave it
to the mozilla folks to update the user agent for future releases not in sync
with the Netscape release schedule.

Comment 6

[Jens-Uwe]

i am for 0.8+ too. 
If and the only thing it does is preventing wrong slashdot announces, because
someone didn't know it better ;-)

Comment 7

[kysmith0 (gone)]

Attachment: diff's for fix to update user agent to 0.8+

Comment 8

[kysmith0 (gone)]

I attached a file (called "diff.txt") with the diff's for the fix, check it out 
and let me know if ok to check in. 

Comment 9

[Jon Granrose]

the one diff looks fine.  what about the mac version though?

Comment 10

[J.J. Enser]

The patch to all.js will affect the user agent on Mac as well.

To update the version number shown in the Macintosh Finder's get info dialog box, 
you would normally need to update mozilla/xpfe/bootstrap/nsMacVersion.r
but I'm planning to revamp this file so I'll take care of the "0.8+" version 
string at the same time. See bug 68231

Comment 11

[Daniel (Leaf) Nunes]

the patch looks good to me, as well; i'll commit this when the tree opens today 
for you, kyle.

Comment 12

[James Green]

Hrm, *poke*. One week after due in and this is either not checked in or hasn't
been marked fixed. Someone wanna do the honours?

Comment 13

[Jon Granrose]

setting TFV for moz 0.81.

has this been checked in yet?  I look at the netscape ua string and it says 0.9
which makes me think we may need to back it down (or we can just wait til we
branch and change it to moz 0.81 on the branch to avoid duplicating effort.

Comment 14

[Asa Dotzler [:asa]]

we should really back this down to 0.8 or 0.8.1 as quickly as possible.  I want
to again recommend something like 0.X+ for the nightlies and 0.X for the
releases.  Flipping it up to the next lited milestone is not good for situations
where we insert a new milestone.  0.X+ solves that by avoiding the next number
until we're there.

Comment 15

[timeless]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/modules/libpref/src/init/al
l.js&rev=3.214&mark=31#24
31 blakeross 3.214 pref("general.useragent.misc", "0.8.1");

Comment 16

[Jacek Piskozub]

The whole discussion ([number]+ versus pre-[number] versus trunk] was already
milled on another bug. BTW, I'm glad my idea of [number]+ is so popular. Do we
implement anything or will we create more situation like the present one where
the seemingly most advanced string (0.9) nightlies  are actually more dated then
the more recent 0.8.1 builds?

Comment 17

[Jon Granrose]

I actually think the trunk mozilla builds should just be "trunk" rather than
x.x+ and we only put actual release numbers on the branches, just like we do for
the directory names for the nightly builds.  That way we don't have to keep
changing things around.

Comment 18

[Jon Granrose]

change summary to reflect reality.  this bug is only concerned with mozilla
0.8.1.  I'll leave it to the mozilla folk to file a bug and figure out how they
want to make the mozilla trunk user agent look.

has the mozilla 0.8.1 user agent been updated yet?  kyle - do you know how to
pull a branch and check in this change to the MOZILLA_0_8_1_BRANCH branch?  If
not, leaf or I can run you through it.

Comment 19

[Asa Dotzler [:asa]]

<trying to avoid adding noise>
The branch is correctly labeled as 0.8.1.  The trunk is also labeled as 0.8.1. 
We should close out this bug as FIXED and file a new one to make the trunk
"trunk" or "nightly" or "0.8.1+" or whatever. 

Comment 20

[J.J. Enser]

mac finder info string is still labeled 0.8+ on both branch and trunk.
this should be kept in synch with the user agent string

Comment 21

[kysmith0 (gone)]

Product is out the door.

Comment 22

[Jon Granrose]

verified fixed.  while I don't recall the bug # offhand, there is another bug
for mozilla 0.9 about changing the user agent string to trunk or 0.8.1+

Comment 23

[J.J. Enser]

Mac finder info string did *not* get updated on the branch, despite my reminder 
above...
Reopening ?

Comment 24

[Jon Granrose]

too late, 0.8.1 has already shipped so there's not anything we can do but
remember to make this change on the 0.9 branch.