Remove PR_TRUE/PR_FALSE from widget/src/gtk2

RESOLVED FIXED in mozilla10

Status

()

Core
Widget: Gtk
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla10
All
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(2 attachments)

Created attachment 563698 [details] [diff] [review]
Patch

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=505027082410

([ ,({])PR_TRUE([ ,);}\n]) and ([ ,({])PR_FALSE([ ,);}\n]) are replaced with true and false. And I fixed two lines which is in string for log (nsDragService::GetData()) manually.
Attachment #563698 - Flags: review?(karlt)

Comment 1

6 years ago
Instead of updating the MAKE_PR_BOOL macro, it looks like you can just remove it entirely. Not only is it generally obsolete but it appears to only be defined and not used.
http://mxr.mozilla.org/mozilla-central/search?string=MAKE_PR_BOOL
Created attachment 564014 [details] [diff] [review]
part.2 Remove MAKE_PR_BOOL

Sure.
Attachment #564014 - Flags: review?(karlt)
NOTE: both MAKE_PR_BOOL have no user.
Attachment #564014 - Flags: review?(karlt) → review+
Comment on attachment 563698 [details] [diff] [review]
Patch

>-  gtk_file_chooser_set_do_overwrite_confirmation(GTK_FILE_CHOOSER(file_chooser), PR_TRUE);
>+  gtk_file_chooser_set_do_overwrite_confirmation(GTK_FILE_CHOOSER(file_chooser), true);

>-    GdkPixbuf* pixbuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, PR_TRUE, 8,
>+    GdkPixbuf* pixbuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, true, 8,

These function expect gboolean, so please use "TRUE" here.

>-    gboolean value = PR_FALSE;
>+    gboolean value = false;

Similarly, "FALSE" here.
Attachment #563698 - Flags: review?(karlt) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/696394093f34
https://hg.mozilla.org/integration/mozilla-inbound/rev/450f539a3dab
Flags: in-testsuite-
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/450f539a3dab
https://hg.mozilla.org/mozilla-central/rev/696394093f34

Please stop doing PR_TRUE/PR_FALSE convertions till the PRBool regression is figured out (see the topic in mozilla.dev.planning)
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Hi,
We are looking into why tp5 for Win7 could have become bimodal after Oct. 3rd in bug 697092.
After much digging up the changeset 696394093f34 has become our main suspect (we're are narrowing down the variables).

Is there any way you think this patch could have caused this?
Any help will be very much appreciated as this type of distributions prevents anyone to determine when new performance regressions happen.

Thanks a lot!

http://graphs-new.mozilla.org/graph.html#tests=[[89,63,12],[115,1,12],[115,63,12]]&sel=1314736531811,1322512531811&displayrange=90&datatype=running
Armen:

This bug just replaced PR_TRUE/PR_FALSE with true/false (or TRUE/FALSE for gboolean).
Answered in bug 697092 comment 13.
You need to log in before you can comment on or make changes to this bug.