690700 - Remove PR_TRUE/PR_FALSE from widget/src/gtk2

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=505027082410

([ ,({])PR_TRUE([ ,);}\n]) and ([ ,({])PR_FALSE([ ,);}\n]) are replaced with true and false. And I fixed two lines which is in string for log (nsDragService::GetData()) manually.

Comment 1

[Dave Garrett]

Instead of updating the MAKE_PR_BOOL macro, it looks like you can just remove it entirely. Not only is it generally obsolete but it appears to only be defined and not used.
http://mxr.mozilla.org/mozilla-central/search?string=MAKE_PR_BOOL

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 Remove MAKE_PR_BOOL

Sure.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

NOTE: both MAKE_PR_BOOL have no user.

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 563698 [details] [diff] [review]
Patch

>-  gtk_file_chooser_set_do_overwrite_confirmation(GTK_FILE_CHOOSER(file_chooser), PR_TRUE);
>+  gtk_file_chooser_set_do_overwrite_confirmation(GTK_FILE_CHOOSER(file_chooser), true);

>-    GdkPixbuf* pixbuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, PR_TRUE, 8,
>+    GdkPixbuf* pixbuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, true, 8,

These function expect gboolean, so please use "TRUE" here.

>-    gboolean value = PR_FALSE;
>+    gboolean value = false;

Similarly, "FALSE" here.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/696394093f34
https://hg.mozilla.org/integration/mozilla-inbound/rev/450f539a3dab

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/450f539a3dab
https://hg.mozilla.org/mozilla-central/rev/696394093f34

Please stop doing PR_TRUE/PR_FALSE convertions till the PRBool regression is figured out (see the topic in mozilla.dev.planning)

Comment 7

[Armen [:armenzg]]

Hi,
We are looking into why tp5 for Win7 could have become bimodal after Oct. 3rd in bug 697092.
After much digging up the changeset 696394093f34 has become our main suspect (we're are narrowing down the variables).

Is there any way you think this patch could have caused this?
Any help will be very much appreciated as this type of distributions prevents anyone to determine when new performance regressions happen.

Thanks a lot!

http://graphs-new.mozilla.org/graph.html#tests=[[89,63,12],[115,1,12],[115,63,12]]&sel=1314736531811,1322512531811&displayrange=90&datatype=running

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Armen:

This bug just replaced PR_TRUE/PR_FALSE with true/false (or TRUE/FALSE for gboolean).

Comment 9

[Karl Tomlinson (:karlt)]

Answered in bug 697092 comment 13.