Future-proof CrashSubmit against future argument additions.

RESOLVED FIXED in seamonkey2.7

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: philip.chee, Assigned: philip.chee)

Tracking

Trunk
seamonkey2.7
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.5 fixed, seamonkey2.6 fixed)

Details

Attachments

(3 attachments)

Port part of Bug 548667 [rewrite CrashSubmit.jsm to use FormData.]
**Note** The parent bug has a Target Milestone: Mozilla 8.

q.v.
  Submit crash reports via FormData.
  http://hg.mozilla.org/mozilla-central/rev/5cabd0a02373
  Future-proof CrashSubmit against future argument additions.
  http://hg.mozilla.org/mozilla-central/rev/03e942f652c1
Attachment #563705 - Flags: review?(neil)
Attachment #563705 - Flags: review?(neil) → review+
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/b7be236800c6
Attachment #563705 - Flags: approval-mozilla-beta?
Attachment #563705 - Flags: approval-mozilla-aurora?
Comment on attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.

not part of our build so plussing
Attachment #563705 - Flags: approval-mozilla-beta?
Attachment #563705 - Flags: approval-mozilla-beta+
Attachment #563705 - Flags: approval-mozilla-aurora?
Attachment #563705 - Flags: approval-mozilla-aurora+
Comment on attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.

Aaaargh. Set the wrong flags.
Attachment #563705 - Flags: approval-comm-beta?
Attachment #563705 - Flags: approval-comm-aurora?
Remove comment obsoleted by the first patch.

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/2f5fc32bffe7
Attachment #565956 - Flags: review+
Comment on attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.

I received a=Callek over IRC
Attachment #563705 - Attachment description: Patch v1.0 Proposed Fix. → Patch v1.0 Proposed Fix. r=Neil a=Callek.
Attachment #563705 - Flags: approval-comm-beta?
Attachment #563705 - Flags: approval-comm-beta+
Attachment #563705 - Flags: approval-comm-aurora?
Attachment #563705 - Flags: approval-comm-aurora+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attachment #565962 - Attachment description: Patches for aurora and beta branches, includes comment removal. rs+a=Callek. → Patch vB1.0 for aurora and beta branches, includes comment removal. rs+a=Callek.
Comment on attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.

Removing wrong mozilla-* flags.
Attachment #563705 - Flags: approval-mozilla-beta+
Attachment #563705 - Flags: approval-mozilla-aurora+
Flags: in-testsuite-
Target Milestone: --- → seamonkey2.7
You need to log in before you can comment on or make changes to this bug.