Future-proof CrashSubmit against future argument additions.

RESOLVED FIXED in seamonkey2.7

Status

SeaMonkey
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Trunk
seamonkey2.7
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.5 fixed, seamonkey2.6 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
Port part of Bug 548667 [rewrite CrashSubmit.jsm to use FormData.]
**Note** The parent bug has a Target Milestone: Mozilla 8.

q.v.
  Submit crash reports via FormData.
  http://hg.mozilla.org/mozilla-central/rev/5cabd0a02373
  Future-proof CrashSubmit against future argument additions.
  http://hg.mozilla.org/mozilla-central/rev/03e942f652c1
(Assignee)

Comment 1

6 years ago
Created attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.
Attachment #563705 - Flags: review?(neil)

Updated

6 years ago
Attachment #563705 - Flags: review?(neil) → review+
(Assignee)

Comment 2

6 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/b7be236800c6
(Assignee)

Updated

6 years ago
Attachment #563705 - Flags: approval-mozilla-beta?
Attachment #563705 - Flags: approval-mozilla-aurora?

Comment 3

6 years ago
Comment on attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.

not part of our build so plussing
Attachment #563705 - Flags: approval-mozilla-beta?
Attachment #563705 - Flags: approval-mozilla-beta+
Attachment #563705 - Flags: approval-mozilla-aurora?
Attachment #563705 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 4

6 years ago
Comment on attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.

Aaaargh. Set the wrong flags.
Attachment #563705 - Flags: approval-comm-beta?
Attachment #563705 - Flags: approval-comm-aurora?
(Assignee)

Comment 5

6 years ago
Created attachment 565956 [details] [diff] [review]
Patch vC1.0 Remove obsoleted comment. rs=Callek.

Remove comment obsoleted by the first patch.

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/2f5fc32bffe7
Attachment #565956 - Flags: review+
(Assignee)

Comment 6

6 years ago
Comment on attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.

I received a=Callek over IRC
Attachment #563705 - Attachment description: Patch v1.0 Proposed Fix. → Patch v1.0 Proposed Fix. r=Neil a=Callek.
Attachment #563705 - Flags: approval-comm-beta?
Attachment #563705 - Flags: approval-comm-beta+
Attachment #563705 - Flags: approval-comm-aurora?
Attachment #563705 - Flags: approval-comm-aurora+
(Assignee)

Comment 7

6 years ago
Created attachment 565962 [details] [diff] [review]
Patch vB1.0 for aurora and beta branches, includes comment removal. rs+a=Callek.

Pushed to branches:
http://hg.mozilla.org/releases/comm-aurora/rev/8b08d6f23c0f
http://hg.mozilla.org/releases/comm-beta/rev/f45eea920d09
Attachment #565962 - Flags: approval-comm-beta+
Attachment #565962 - Flags: approval-comm-aurora+
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Attachment #565962 - Attachment description: Patches for aurora and beta branches, includes comment removal. rs+a=Callek. → Patch vB1.0 for aurora and beta branches, includes comment removal. rs+a=Callek.
(Assignee)

Comment 8

6 years ago
Comment on attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.

Removing wrong mozilla-* flags.
Attachment #563705 - Flags: approval-mozilla-beta+
Attachment #563705 - Flags: approval-mozilla-aurora+
status-seamonkey2.5: affected → fixed
status-seamonkey2.6: affected → fixed
status-seamonkey2.7: affected → ---
Flags: in-testsuite-
Target Milestone: --- → seamonkey2.7
You need to log in before you can comment on or make changes to this bug.