690706 - Future-proof CrashSubmit against future argument additions.

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Philip Chee]

Port part of Bug 548667 [rewrite CrashSubmit.jsm to use FormData.]
**Note** The parent bug has a Target Milestone: Mozilla 8.

q.v.
  Submit crash reports via FormData.
  http://hg.mozilla.org/mozilla-central/rev/5cabd0a02373
  Future-proof CrashSubmit against future argument additions.
  http://hg.mozilla.org/mozilla-central/rev/03e942f652c1

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed Fix. r=Neil a=Callek.

Comment 2

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/b7be236800c6

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.

not part of our build so plussing

Comment 4

[Philip Chee]

Comment on attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.

Aaaargh. Set the wrong flags.

Comment 5

[Philip Chee]

Attachment: Patch vC1.0 Remove obsoleted comment. rs=Callek.

Remove comment obsoleted by the first patch.

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/2f5fc32bffe7

Comment 6

[Philip Chee]

Comment on attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.

I received a=Callek over IRC

Comment 7

[Philip Chee]

Attachment: Patch vB1.0 for aurora and beta branches, includes comment removal. rs+a=Callek.

Pushed to branches:
http://hg.mozilla.org/releases/comm-aurora/rev/8b08d6f23c0f
http://hg.mozilla.org/releases/comm-beta/rev/f45eea920d09

Comment 8

[Philip Chee]

Comment on attachment 563705 [details] [diff] [review]
Patch v1.0 Proposed Fix. r=Neil a=Callek.

Removing wrong mozilla-* flags.