GCLI web tests should be capable of being run in the browser

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

Trunk
Firefox 10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Created attachment 565612 [details] [diff] [review]
upload 1

Rob - I'm not sure how much of a review this needs
- it's just tests for GCLI
- the parts have been reviewed as part of GCLI's normal process, so r+fitzgan and r+mikeratcliffe
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #565612 - Flags: review?(rcampbell)
I should add - there is an error somewhere, which is causing an error which creates a memory leak. I'll be fixing that first thing next week, and then assuming review is OK, we can land this.
Depends on: 656666
Blocks: 692424
I get this:

TEST-START | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser/browser_gcli_web.js
error
  Failed to lookup
  cliEvalJavascript
  ...

TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser/browser_gcli_web.js | Console message: [JavaScript Error: "redeclaration of var Cc" {file: "chrome://browser/content/content.js" line: 3}]
error
  Failed to lookup
  canonDescNone
  ...
error
  Test Failure
  require is not defined
    - stack = onLoad([object Event])@chrome://mochitests/content/browser/browser/devtools/web_

INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser/browser_gcli_web.js | finished in 1049ms

INFO TEST-START | Shutdown
Browser Chrome Test Summary
	Passed: 0
	Failed: 0
	Todo: 0


When there are execution errors we want to have them reported, not hidden, otherwise we'll never know if these tests become broken by some other patch we push to the repo. This test, for example, should have shown at least a failure.
Created attachment 566213 [details] [diff] [review]
upload 2

upload 1 was broken by some refactoring in another bug.
This is now clean for me.

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=fb5797f41c92
Attachment #565612 - Attachment is obsolete: true
Attachment #565612 - Flags: review?(rcampbell)
Attachment #566213 - Flags: review?(rcampbell)
Comment on attachment 566213 [details] [diff] [review]
upload 2

r+ with successful try push.
Attachment #566213 - Flags: review?(rcampbell) → review+
2 github pull requests contributed reviews to this bug:
https://github.com/mozilla/gcli/pull/33
https://github.com/mozilla/gcli/pull/34
Try log:
https://tbpl.mozilla.org/?tree=Try&rev=f2eedda104b1
upload 2: https://hg.mozilla.org/integration/fx-team/rev/967846102da6
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/967846102da6
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
You need to log in before you can comment on or make changes to this bug.