[TABLETUI] Remove dotted line in border on New Tab button

VERIFIED FIXED in Firefox 10

Status

defect
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: aaronmt, Assigned: lucasr)

Tracking

({regression})

Firefox Tracking Flags

(firefox9 unaffected)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Posted image Nightly (09/30)
See screenshot. Aurora (09/30) is unaffected.

--
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20110930 Firefox/10.0a1 Fennec/10.0a1
Galaxy Tab 10.1 (Android 3.1)
Assignee: nobody → lucasr.at.mozilla
Attachment #564153 - Flags: review?(wjohnston)
Comment on attachment 564153 [details] [diff] [review]
Remove unwanted dotted line borders from tabs popup

I think we could be more general about this. We don't want _any_ buttons/toolbarbuttons to have the dotted line focus ring.
Here's a more general patch to remove all button focus dotted borders.
Attachment #564153 - Attachment is obsolete: true
Attachment #564153 - Flags: review?(wjohnston)
Attachment #564172 - Flags: review?(wjohnston)
I am a bit nervous this will make it hard to do any keyboard navigation on Fennec. Its already pretty difficult to tell what's focused. I don't want to compound the problem more. I don't have strong feelings about this. Otherwise the patch is fine. Just want mfinkle to confirm we're ok with it.
Mark, suggestions? Maybe only change the new tab and close buttons?

We'd have to do a lot of fixes in order to get keyboard navigation working nicely anyway. The current dotted border looks misplaced.
Two things:
* We'll need to deal with "tab navigation" on it's own and it will probably be a bit tough. This change won't hurt us until then.
* Why aren't these 2 buttons toolbarbuttons, which already hide the focus outline?
(In reply to Mark Finkle (:mfinkle) from comment #6)
> * Why aren't these 2 buttons toolbarbuttons, which already hide the focus
> outline?

I remember Wes commented in some other bug that he used button (instead of  toolbarbutton) in order to get the alignment right or something. Wes, confirm?
Attachment #564172 - Flags: review?(wjohnston) → review+
toolbarbuttons have an extra flex on their label:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/toolbarbutton.xml#14

while buttons do not:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/button.xml#214

The flex makes layout difficult. We should go remove it and put it in the toolkit stylesheets instead. filed bug 693367
Attachment #564153 - Attachment is obsolete: false
Attachment #564172 - Attachment is obsolete: true
Attachment #564153 - Flags: review+
Landed the first patch: http://hg.mozilla.org/integration/mozilla-inbound/rev/a9eacbb0e411
Target Milestone: --- → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/a9eacbb0e411
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111031 Firefox/10.0a1 Fennec/10.0a1
Device: Asus Transformer TF101 - Android 3.1

Dotted line in border on New Tab button was removed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.