690900 - [TABLETUI] Remove dotted line in border on New Tab button

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (09/30)

See screenshot. Aurora (09/30) is unaffected.

--
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20110930 Firefox/10.0a1 Fennec/10.0a1
Galaxy Tab 10.1 (Android 3.1)

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Remove unwanted dotted line borders from tabs popup

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 564153 [details] [diff] [review]
Remove unwanted dotted line borders from tabs popup

I think we could be more general about this. We don't want _any_ buttons/toolbarbuttons to have the dotted line focus ring.

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Remove unwanted dotted line borders from tabs popup

Here's a more general patch to remove all button focus dotted borders.

Comment 4

[Wesley Johnston (:wesj)]

I am a bit nervous this will make it hard to do any keyboard navigation on Fennec. Its already pretty difficult to tell what's focused. I don't want to compound the problem more. I don't have strong feelings about this. Otherwise the patch is fine. Just want mfinkle to confirm we're ok with it.

Comment 5

[Lucas Rocha (:lucasr)]

Mark, suggestions? Maybe only change the new tab and close buttons?

We'd have to do a lot of fixes in order to get keyboard navigation working nicely anyway. The current dotted border looks misplaced.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Two things:
* We'll need to deal with "tab navigation" on it's own and it will probably be a bit tough. This change won't hurt us until then.
* Why aren't these 2 buttons toolbarbuttons, which already hide the focus outline?

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #6)
> * Why aren't these 2 buttons toolbarbuttons, which already hide the focus
> outline?

I remember Wes commented in some other bug that he used button (instead of  toolbarbutton) in order to get the alignment right or something. Wes, confirm?

Comment 8

[Wesley Johnston (:wesj)]

toolbarbuttons have an extra flex on their label:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/toolbarbutton.xml#14

while buttons do not:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/button.xml#214

The flex makes layout difficult. We should go remove it and put it in the toolkit stylesheets instead. filed bug 693367

Comment 9

[Lucas Rocha (:lucasr)]

Landed the first patch: http://hg.mozilla.org/integration/mozilla-inbound/rev/a9eacbb0e411

Comment 10

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/a9eacbb0e411

Comment 11

[Camelia Urian]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111031 Firefox/10.0a1 Fennec/10.0a1
Device: Asus Transformer TF101 - Android 3.1

Dotted line in border on New Tab button was removed.