69101 - Things that slow down mac painting

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Mike Pinkerton (not reading bugmail)]

Two things i found that slowed down painting on mac:

The first was, for multi monitor systems, we were taking about 8% of the time to 
calculate which screen the device content was on. All of this time, however, was 
taken up by subtracting out the height of the titlebar from the window rect. Why 
we were doing this, I don't know, but since it's only an approximation anyway, it 
really doesn't matter if we do or don't include the title bar. Removing the title 
bar code dropped GetScreenForSurface() off the radar.

Second, there are 2 places in nsCSSRenderer where we use paths to approximate 
rounded borders (nsCSSPaintRoundedBorder and nsCSSPaintRoundedBackground). Each 
routine has a stack-based array of 1000 nsPoints (!!!). Initializing this array 
took 18% (!) of the all paint time, and over 65% of the time in these routines. 
Making these two arrays static dropped these routines more or less of the radar.

I already have r=saari, dcone do you object to the static's in the CSS rendering 
code (it's your code)?

patch for both forthcoming.

Comment 1

[Mike Pinkerton (not reading bugmail)]

Attachment: patch for both problems

Comment 2

[dcone (gone)]

For that particular code.. Peter L(long gone) was suppose to give me a data 
structure to use for those points that was faster and lighter.. but when he left 
I totally forgot about that.  good find!  r=dcone.  

Comment 3

[Simon Fraser [no longer active]]

sr=sfraser

Comment 4

[Mike Pinkerton (not reading bugmail)]

both patches checked in.

Comment 5

[Chris Petersen]

Marking verified per last comments.