691100 - Read It Later (and apparently Omnibar) cause location bar to be taller than usual

Status: RESOLVED INVALID

(Firefox :: Extension Compatibility, defect)

Description

[Joe Drew (not getting mail)]

Ever since bug 684450 landed, Read It Later causes my location bar to be bigger than it should be. Stephen Horlander says in bug 684450 comment 22:

> It looks like extensions that add items to the #urlbar-icon hbox are
> affected by this. So far I have only found Omnibar and Read It Later.
> 
> Both of them are adding their own padding, which should be fine, but for
> some reason both of them are adding the .urlbar-icons class to the
> #urlbar-icon hbox.

This should be fixed (or ignored and documented).

Comment 1

[Dão Gottwald [:dao]]

> > both of them are adding the .urlbar-icons class to the
> > #urlbar-icon hbox.

This is their bug. Afaik omnibar is already fixed.

Comment 2

[Joe Drew (not getting mail)]

Has it been documented? What were they doing wrong?

Comment 3

[Dão Gottwald [:dao]]

They were arbitrarily and needlessly setting a CSS class on a node where it makes no sense. Since it never made sense, we don't need to document this.