691118 - "ASSERTION: aPrevFrame must be the last continuation in its chain!"

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: aPrevFrame must be the last continuation in its chain!: '!aPrevFrame || (!aPrevFrame->GetNextContinuation() || IS_TRUE_OVERFLOW_CONTAINER(aPrevFrame->GetNextContinuation())) && !IS_TRUE_OVERFLOW_CONTAINER(aPrevFrame)', file layout/base/nsFrameManager.cpp, line 497

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Timothy Nikkel (:tnikkel)]

Caused by something between fc7e928eaeae and af3668a89015, ie bug 10209.

Comment 3

[(no longer active)]

Attachment: Patch (v1)

I don't think that the assertion actually makes any sense for absolute frames.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Why's that?

Comment 5

[(no longer active)]

Because we're not appending a frame after aPrevFrame.  Or at least, it should be possible to append an absolute frame in that case.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

aPrevFrame would be the previous abs-pos frame.

Comment 7

[(no longer active)]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #6)
> aPrevFrame would be the previous abs-pos frame.

But still, does the assertion make sense?  We don't require abs-pos frames to be overflow containers, right?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

They can't be true overflow containers, actually. See the definition of IS_TRUE_OVERFLOW_CONTAINER.

I think probably instead of checking IS_TRUE_OVERFLOW_CONTAINER we should just check for the NS_FRAME_IS_OVERFLOW_CONTAINER state bit.

Comment 9

[(no longer active)]

Attachment: Patch (v2)

Comment 10

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56ee31100cf6

Comment 11

[Mozilla RelEng Bot]

Try run for 689ef914ab82 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=689ef914ab82
Results (out of 208 total builds):
    exception: 3
    success: 181
    warnings: 23
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-689ef914ab82

Comment 12

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/56ee31100cf6