"ASSERTION: aPrevFrame must be the last continuation in its chain!"

RESOLVED FIXED in mozilla12

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: Ehsan)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla12
x86
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 564018 [details]
testcase

###!!! ASSERTION: aPrevFrame must be the last continuation in its chain!: '!aPrevFrame || (!aPrevFrame->GetNextContinuation() || IS_TRUE_OVERFLOW_CONTAINER(aPrevFrame->GetNextContinuation())) && !IS_TRUE_OVERFLOW_CONTAINER(aPrevFrame)', file layout/base/nsFrameManager.cpp, line 497
(Reporter)

Comment 1

6 years ago
Created attachment 564019 [details]
stack trace
Caused by something between fc7e928eaeae and af3668a89015, ie bug 10209.
Blocks: 10209
Created attachment 565635 [details] [diff] [review]
Patch (v1)

I don't think that the assertion actually makes any sense for absolute frames.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #565635 - Flags: review?(roc)
Why's that?
Because we're not appending a frame after aPrevFrame.  Or at least, it should be possible to append an absolute frame in that case.
aPrevFrame would be the previous abs-pos frame.
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #6)
> aPrevFrame would be the previous abs-pos frame.

But still, does the assertion make sense?  We don't require abs-pos frames to be overflow containers, right?
They can't be true overflow containers, actually. See the definition of IS_TRUE_OVERFLOW_CONTAINER.

I think probably instead of checking IS_TRUE_OVERFLOW_CONTAINER we should just check for the NS_FRAME_IS_OVERFLOW_CONTAINER state bit.
Created attachment 585539 [details] [diff] [review]
Patch (v2)
Attachment #565635 - Attachment is obsolete: true
Attachment #565635 - Flags: review?(roc)
Attachment #585539 - Flags: review?(roc)
Attachment #585539 - Flags: review?(roc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/56ee31100cf6
Flags: in-testsuite+
Target Milestone: --- → mozilla12

Comment 11

6 years ago
Try run for 689ef914ab82 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=689ef914ab82
Results (out of 208 total builds):
    exception: 3
    success: 181
    warnings: 23
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-689ef914ab82
https://hg.mozilla.org/mozilla-central/rev/56ee31100cf6
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.