Closed
Bug 691138
Opened 13 years ago
Closed 13 years ago
ipc: AURORA_BASE_20110927 fails to build darwin/x11
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: jeremyhu, Assigned: jeremyhu)
Details
Attachments
(1 file)
6.20 KB,
patch
|
smichaud
:
review+
|
Details | Diff | Splinter Review |
6dc468c41136 (20110820) built fine, but the AURORA_BASE_20110927 tag fails with various issues in ipc (probably because someone assumed darwin == cocoa): ../../ipc/chromium/src/chrome/common/mach_ipc_mac.h:116:3: warning: conversion function converting 'MachMsgPortDescriptor' to its base class 'mach_msg_port_descriptor_t' will never be used operator mach_msg_port_descriptor_t&() { ^ /opt/local/var/macports/build/_Volumes_Home_jeremy_src_macports_trunk_dports_www_firefox-x11-devel/firefox-x11-devel/work/mozilla-central/ipc/glue/GeckoChildProcessHost.cpp:49:10: fatal error: 'nsILocalFileMac.h' file not found #include "nsILocalFileMac.h" ^ 1 warning and 1 error generated. make[1]: *** [GeckoChildProcessHost.o] Error 1
Updated•13 years ago
|
Attachment #564041 -
Attachment is patch: true
Attachment #564041 -
Flags: review?(joshmoz)
Attachment #564041 -
Flags: review?(joshmoz) → review?(smichaud)
Comment 1•13 years ago
|
||
Comment on attachment 564041 [details] [diff] [review] patch This looks fine to me. XP_MACOSX and MOZ_WIDGET_COCOA are always synonyms when doing a "normal" build on "normal" OS X. So this change can't harm any of our supported configurations. It might (conceivably) cause trouble for someone trying to do a GTK or QT build on OS X or (non-Cocoa) Darwin. But it sounds like the very reason for you wanting these changes is to make this kind of "non normal" (non-supported) build possible. So I'll take your word for it that this helps, but we'll need to keep an eye out for problems. By the way, I suspect there are many places in the tree where XP_MACOSX sections of code contain Cocoa dependencies.
Attachment #564041 -
Flags: review?(smichaud) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Yes, and it seems like every 3-6 months, I need to send a handful of patches to mozilla to fix cases where people forget that. This last month or so has been especially bad. August 20th master built fine, but one month later (9/27) had tons of fallout. I've submitted multiple patches, but they're insufficient. I haven't had time to fix the remainder.
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6715771c1d9a
Assignee: nobody → jeremyhu
Whiteboard: [inbound]
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6715771c1d9a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•